ARM: dts: veyron: enable the tsadc on pinky board
diff mbox

Message ID 1450607434-6733-1-git-send-email-wxt@rock-chips.com
State New
Headers show

Commit Message

Caesar Wang Dec. 20, 2015, 10:30 a.m. UTC
I think the tsadc is fakly hand on pinky board,
maybe that's fixed in newest kernel.
As the following patch is a example:
https://patchwork.kernel.org/patch/7472051/

I don't have meet this issue on pinky board.
Let me know if that's still hanging on pinky board.

Signed-off-by: Caesar Wang <wxt@rock-chips.com>
---

 arch/arm/boot/dts/rk3288-veyron-pinky.dts | 5 -----
 1 file changed, 5 deletions(-)

Comments

Heiko Stübner March 24, 2016, 9:12 p.m. UTC | #1
Hi Caesar,

Am Sonntag, 20. Dezember 2015, 18:30:34 schrieb Caesar Wang:
> I think the tsadc is fakly hand on pinky board,
> maybe that's fixed in newest kernel.
> As the following patch is a example:
> https://patchwork.kernel.org/patch/7472051/
> 
> I don't have meet this issue on pinky board.
> Let me know if that's still hanging on pinky board.
> 
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>

I just gave that a try again on my pinky-rev2. And while the tsadc did produce 
some results and didn't hang the system in my tries, the temperature values 
seemed to be frozen (only changing once on every reboot).

Running the same kernel on a Jerry produced the expected results of the 
temperature changing over time and differing cpu frequencies.

Pinky also is a sort of dinosaur and only you and me seem to still like them 
:-) . And something is definitly strange here, and I'd tend to keep the tsadc 
disabled for the time being. 


Heiko
Heiko Stübner March 27, 2016, 9:30 p.m. UTC | #2
Hi Caesar,

Am Freitag, 25. März 2016, 08:58:01 schrieb Caesar Wang:
> ? 2016?03?25? 05:12, Heiko Stübner ??:
> > Am Sonntag, 20. Dezember 2015, 18:30:34 schrieb Caesar Wang:
> >> I think the tsadc is fakly hand on pinky board,
> >> maybe that's fixed in newest kernel.
> >> As the following patch is a example:
> >> https://patchwork.kernel.org/patch/7472051/
> >> 
> >> I don't have meet this issue on pinky board.
> >> Let me know if that's still hanging on pinky board.
> >> 
> >> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> > 
> > I just gave that a try again on my pinky-rev2. And while the tsadc did
> > produce some results and didn't hang the system in my tries, the
> > temperature values seemed to be frozen (only changing once on every
> > reboot).
> > 
> > Running the same kernel on a Jerry produced the expected results of the
> > temperature changing over time and differing cpu frequencies.
> > 
> > Pinky also is a sort of dinosaur and only you and me seem to still like
> > them> 
> > :-) . And something is definitly strange here, and I'd tend to keep the
> > :tsadc> 
> > disabled for the time being.
> 
> I remember the same issue on
> https://code.google.com/p/chrome-os-partner/issues/detail?id=35060 in
> the past
> 
> "thermal can 't work if  the hardware C1106 isn't removed in the
> attachment."
> 
> So I think you can change this early board.

As I'm a total noob when it comes to soldering (especially on such a tiny 
scale), I don't think that is an option ;-) .

Reading that bug report again, brought back memories, that exactly this was 
the issue why suspend didn't work correctly for me then.

So I still think I'll keep the tsadc on pinky as it is now - as I said before, 
it looks like you and me are the only people still caring for pinky and 
everybody else most likely put theirs into the trash already, so nothing 
terrible important is affected by this :-)


Heiko

Patch
diff mbox

diff --git a/arch/arm/boot/dts/rk3288-veyron-pinky.dts b/arch/arm/boot/dts/rk3288-veyron-pinky.dts
index 94b56e3..b587ebf 100644
--- a/arch/arm/boot/dts/rk3288-veyron-pinky.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-pinky.dts
@@ -121,8 +121,3 @@ 
 		     &sdmmc_wp_gpio &sdmmc_bus4>;
 	wp-gpios = <&gpio7 10 GPIO_ACTIVE_HIGH>;
 };
-
-&tsadc {
-	/* Some connection is flaky making the tsadc hang the system */
-	status = "disabled";
-};