diff mbox

[v1,2/2] dt-bindings: sound: add devicetree document for rt5616

Message ID 1450709768-14898-1-git-send-email-wxt@rock-chips.com (mailing list archive)
State New, archived
Headers show

Commit Message

Caesar Wang Dec. 21, 2015, 2:56 p.m. UTC
Add the description for rt5616 codec.

Signed-off-by: Caesar Wang <wxt@rock-chips.com>

---

Changes in v1:
- As Heiko comments, remove the not exist option properties.

 Documentation/devicetree/bindings/sound/rt5616.txt | 36 ++++++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/rt5616.txt

Comments

Caesar Wang Dec. 22, 2015, 12:54 a.m. UTC | #1
Hi

? 2015?12?22? 05:15, Frank Rowand ??:
> On 12/21/2015 6:56 AM, Caesar Wang wrote:
>> Add the description for rt5616 codec.
>>
>> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
>>
>> ---
>>
>> Changes in v1:
>> - As Heiko comments, remove the not exist option properties.
>>
>>   Documentation/devicetree/bindings/sound/rt5616.txt | 36 ++++++++++++++++++++++
>>   1 file changed, 36 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/sound/rt5616.txt
>>
>> diff --git a/Documentation/devicetree/bindings/sound/rt5616.txt b/Documentation/devicetree/bindings/sound/rt5616.txt
>> new file mode 100644
>> index 0000000..2030a22
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/rt5616.txt
>> @@ -0,0 +1,36 @@
>> +RT5616 audio CODEC
>> +
>> +This device supports I2C only.
>> +
>> +Required properties:
>> +
>> +- compatible : "realtek,rt5616".
>> +
>> +- reg : The I2C address of the device.
>> +
>> +Pins on the device (for linking into audio routes) for RT5616:
>> +
>> +  * IN1P
>> +  * IN2P
>> +  * IN2N
>> +  * LOUTL
>> +  * LOUTR
>> +  * CPN2
>> +  * CPP2
>> +  * CPN1
>> +  * CPP1
>> +  * HPO_R
>> +  * HPO_L
>> +  * ADCDAT1
>> +  * DACDAT1
>> +  * LRCK1
>> +  * BCLK1
>> +  * MCLK
>> +  * GPIO1
>> +
>> +Example:
>> +
>> +rt5616 {
> The node name should be rt5616@1b (including the reg value
> from the node).

In general, that's right.

Okay, fixed in next version.


>
>> +	compatible = "realtek,rt5616";
>> +	reg = <0x1b>;
>> +};
>>
>
>
>
Bard Liao Dec. 22, 2015, 1:50 a.m. UTC | #2
> -----Original Message-----
> From: Caesar Wang [mailto:wxt@rock-chips.com]
> Sent: Monday, December 21, 2015 10:56 PM
> To: broonie@kernel.org; robh+dt@kernel.org
> Cc: linux-kernel@vger.kernel.org; devicetree@vger.kernel.org;
> alsa-devel@alsa-project.org; Bard Liao; heiko@sntech.de; Caesar Wang
> Subject: [PATCH v1 2/2] dt-bindings: sound: add devicetree document for
> rt5616
> 
> Add the description for rt5616 codec.
> 
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> 
> ---
> 
> Changes in v1:
> - As Heiko comments, remove the not exist option properties.
> 
>  Documentation/devicetree/bindings/sound/rt5616.txt | 36
> ++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/sound/rt5616.txt
> 
> diff --git a/Documentation/devicetree/bindings/sound/rt5616.txt
> b/Documentation/devicetree/bindings/sound/rt5616.txt
> new file mode 100644
> index 0000000..2030a22
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/rt5616.txt
> @@ -0,0 +1,36 @@
> +RT5616 audio CODEC
> +
> +This device supports I2C only.
> +
> +Required properties:
> +
> +- compatible : "realtek,rt5616".
> +
> +- reg : The I2C address of the device.
> +
> +Pins on the device (for linking into audio routes) for RT5616:
> +
> +  * IN1P
> +  * IN2P
> +  * IN2N
> +  * LOUTL
> +  * LOUTR

These names below seems not defined in rt5616_dapm_widgets.
Where are they from?

> +  * CPN2
> +  * CPP2
> +  * CPN1
> +  * CPP1
> +  * HPO_R
> +  * HPO_L
> +  * ADCDAT1
> +  * DACDAT1
> +  * LRCK1
> +  * BCLK1
> +  * MCLK
> +  * GPIO1
> +
> +Example:
> +
> +rt5616 {
> +	compatible = "realtek,rt5616";
> +	reg = <0x1b>;
> +};
> --
> 1.9.1
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/sound/rt5616.txt b/Documentation/devicetree/bindings/sound/rt5616.txt
new file mode 100644
index 0000000..2030a22
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/rt5616.txt
@@ -0,0 +1,36 @@ 
+RT5616 audio CODEC
+
+This device supports I2C only.
+
+Required properties:
+
+- compatible : "realtek,rt5616".
+
+- reg : The I2C address of the device.
+
+Pins on the device (for linking into audio routes) for RT5616:
+
+  * IN1P
+  * IN2P
+  * IN2N
+  * LOUTL
+  * LOUTR
+  * CPN2
+  * CPP2
+  * CPN1
+  * CPP1
+  * HPO_R
+  * HPO_L
+  * ADCDAT1
+  * DACDAT1
+  * LRCK1
+  * BCLK1
+  * MCLK
+  * GPIO1
+
+Example:
+
+rt5616 {
+	compatible = "realtek,rt5616";
+	reg = <0x1b>;
+};