Message ID | fea57694a17b8001b53896f657ffccf5128ee4c3.1450713219.git.geliangtang@163.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Mon, 21 Dec 2015 16:55:39 +0100, Geliang Tang wrote: > > For better readability, use list_for_each_entry_continue_reverse() > in have_dup_chmap(). > > Signed-off-by: Geliang Tang <geliangtang@163.com> Applied, thanks. Takashi > --- > sound/usb/stream.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/sound/usb/stream.c b/sound/usb/stream.c > index 8ee14f2..c4dc577 100644 > --- a/sound/usb/stream.c > +++ b/sound/usb/stream.c > @@ -125,11 +125,9 @@ static int usb_chmap_ctl_info(struct snd_kcontrol *kcontrol, > static bool have_dup_chmap(struct snd_usb_substream *subs, > struct audioformat *fp) > { > - struct list_head *p; > + struct audioformat *prev = fp; > > - for (p = fp->list.prev; p != &subs->fmt_list; p = p->prev) { > - struct audioformat *prev; > - prev = list_entry(p, struct audioformat, list); > + list_for_each_entry_continue_reverse(prev, &subs->fmt_list, list) { > if (prev->chmap && > !memcmp(prev->chmap, fp->chmap, sizeof(*fp->chmap))) > return true; > -- > 2.5.0 > > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >
diff --git a/sound/usb/stream.c b/sound/usb/stream.c index 8ee14f2..c4dc577 100644 --- a/sound/usb/stream.c +++ b/sound/usb/stream.c @@ -125,11 +125,9 @@ static int usb_chmap_ctl_info(struct snd_kcontrol *kcontrol, static bool have_dup_chmap(struct snd_usb_substream *subs, struct audioformat *fp) { - struct list_head *p; + struct audioformat *prev = fp; - for (p = fp->list.prev; p != &subs->fmt_list; p = p->prev) { - struct audioformat *prev; - prev = list_entry(p, struct audioformat, list); + list_for_each_entry_continue_reverse(prev, &subs->fmt_list, list) { if (prev->chmap && !memcmp(prev->chmap, fp->chmap, sizeof(*fp->chmap))) return true;
For better readability, use list_for_each_entry_continue_reverse() in have_dup_chmap(). Signed-off-by: Geliang Tang <geliangtang@163.com> --- sound/usb/stream.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)