From patchwork Mon Dec 21 20:49:39 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Jarzmik X-Patchwork-Id: 7897721 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2EA38BEEE5 for ; Mon, 21 Dec 2015 20:49:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1DAF02026C for ; Mon, 21 Dec 2015 20:49:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD5FC20259 for ; Mon, 21 Dec 2015 20:49:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750812AbbLUUtq (ORCPT ); Mon, 21 Dec 2015 15:49:46 -0500 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:47873 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750802AbbLUUtp (ORCPT ); Mon, 21 Dec 2015 15:49:45 -0500 Received: from belgarion ([92.136.74.210]) by mwinf5d53 with ME id wLpf1r00M4YDnlY03LpfQK; Mon, 21 Dec 2015 21:49:41 +0100 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 21 Dec 2015 21:49:41 +0100 X-ME-IP: 92.136.74.210 From: Robert Jarzmik To: Michal Marek Cc: linux-kbuild@vger.kernel.org Subject: kbuild: global makefile and spaces in path X-URL: http://belgarath.falguerolles.org/ Date: Mon, 21 Dec 2015 21:49:39 +0100 Message-ID: <87lh8nfrx8.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Michal, I compiled my kernel in a directory /home/robert jarzmik/kernel, and that's the first time I encountered a space in the path containing my kernel in years. I was wondering if there is a known constraint that the linux kernel source should be contained within a path without any space ? If no such constraint is known, maybe you could consider the patch in [1]. Cheers. diff --git a/Makefile b/Makefile index 7ce5c5a76c0b..45ec34644b4f 100644 --- a/Makefile +++ b/Makefile @@ -1119,16 +1119,16 @@ modules_install: _modinst_ _modinst_post PHONY += _modinst_ _modinst_: - @rm -rf $(MODLIB)/kernel - @rm -f $(MODLIB)/source - @mkdir -p $(MODLIB)/kernel - @ln -s `cd $(srctree) && /bin/pwd` $(MODLIB)/source - @if [ ! $(objtree) -ef $(MODLIB)/build ]; then \ - rm -f $(MODLIB)/build ; \ - ln -s $(CURDIR) $(MODLIB)/build ; \ + @rm -rf "$(MODLIB)"/kernel + @rm -f "$(MODLIB)"/source + @mkdir -p "$(MODLIB)"/kernel + @ln -s "`cd $(srctree) && /bin/pwd`" "$(MODLIB)"/source + @if [ ! "$(objtree)" -ef "$(MODLIB)"/build ]; then \ + rm -f "$(MODLIB)"/build ; \ + ln -s "$(CURDIR)" "$(MODLIB)"/build ; \ fi - @cp -f $(objtree)/modules.order $(MODLIB)/ - @cp -f $(objtree)/modules.builtin $(MODLIB)/ + @cp -f $(objtree)/modules.order "$(MODLIB)"/ + @cp -f $(objtree)/modules.builtin "$(MODLIB)"/ $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modinst # This depmod is only for convenience to give the initial