[1/4] net: ethernet: arc: Probe emac after set RMII clock
diff mbox

Message ID 1450862390-407-1-git-send-email-zhengxing@rock-chips.com
State New
Headers show

Commit Message

zhengxing Dec. 23, 2015, 9:19 a.m. UTC
After enter arc_emac_probe, emac will get_phy_id, phy_poll_reset and
other connecting PHY via mdiobus_read, so we need to set correct
ref clock rate for emac before probe emac.

Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
---

 drivers/net/ethernet/arc/emac_rockchip.c |   11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

Comments

David Miller Dec. 28, 2015, 5:14 a.m. UTC | #1
I only see 3 patches in this series.

Furthermore, you failed to provide a proper "[PATCH 0/4] xxx" posting
providing a high level description of what this series is doing, and
how it is doing it, and why.

Thanks.
zhengxing Dec. 28, 2015, 7:27 a.m. UTC | #2
Hi David,
Sorry, I missed the cover letter.
I have added it and resent the patchset.

Thanks.

- Xing Zheng

On 2015?12?28? 13:14, David Miller wrote:
> I only see 3 patches in this series.
>
> Furthermore, you failed to provide a proper "[PATCH 0/4] xxx" posting
> providing a high level description of what this series is doing, and
> how it is doing it, and why.
>
> Thanks.
>
>
>

Patch
diff mbox

diff --git a/drivers/net/ethernet/arc/emac_rockchip.c b/drivers/net/ethernet/arc/emac_rockchip.c
index c31c740..36e9eb1 100644
--- a/drivers/net/ethernet/arc/emac_rockchip.c
+++ b/drivers/net/ethernet/arc/emac_rockchip.c
@@ -164,10 +164,6 @@  static int emac_rockchip_probe(struct platform_device *pdev)
 		}
 	}
 
-	err = arc_emac_probe(ndev, interface);
-	if (err)
-		goto out_regulator_disable;
-
 	/* write-enable bits */
 	data = GRF_MODE_ENABLE_BIT | GRF_SPEED_ENABLE_BIT;
 
@@ -184,6 +180,13 @@  static int emac_rockchip_probe(struct platform_device *pdev)
 	err = clk_set_rate(priv->refclk, 50000000);
 	if (err)
 		dev_err(dev, "failed to change reference clock rate (%d)\n", err);
+
+	err = arc_emac_probe(ndev, interface);
+	if (err) {
+		dev_err(dev, "failed to probe arc emac (%d)\n", err);
+		goto out_regulator_disable;
+	}
+
 	return 0;
 
 out_regulator_disable: