| Message ID | 1452078523-19830-1-git-send-email-ian.campbell@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 2016-01-06 at 11:08 +0000, Ian Campbell wrote: ping? > Currently the bgcolor of the osstest column alternates on each line, > rather than only when it changes as the other revision columns do. > > A given flight might touch multiple osstest revisions (although in > practice they rarely do) but it seems reasonable to simply consider > any change as a change. > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > --- > sg-report-job-history | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/sg-report-job-history b/sg-report-job-history > index 0e2a3f9..e2e5806 100755 > --- a/sg-report-job-history > +++ b/sg-report-job-history > @@ -234,6 +234,7 @@ END > my @last_revs; > my @alt_revs; > my $alt_hosts; > + my $alt_osstest; > foreach my $r (@test_rows) { > my $altcolour= report_altcolour($alternate); > print H "<tr $altcolour>"; > @@ -254,16 +255,15 @@ END > my $hosts_colour = report_altchangecolour(\$alt_hosts, > $hosts); > print H "<td > $hosts_colour>".encode_entities($hosts)."</td>\n"; > $osstestverq->execute($r->{Flight}{flight}); > - print H > - "<td>", > - (join ' ', > + my $osstestrevs = join ' ', > map { > $_ = $_->{harness}; > s/^([0-9a-f]{12})[0-9a-f]+\b/$1/; > "<kbd>".encode_entities($_)."</kbd>"; > } > - @{ $osstestverq->fetchall_arrayref({}) }), > - "</td>\n"; > + @{ $osstestverq->fetchall_arrayref({}) }; > + my $osstest_colour = report_altchangecolour(\$alt_osstest, > $osstestrevs); > + print H "<td $osstest_colour>$osstestrevs</td>\n"; > foreach my $i (0..$#rev_grid_cols) { > my $v= $r->{Revisions}[$i]; > my $rev_colour = report_altchangecolour(\$alt_revs[$i], > $v);
Ian Campbell writes ("Re: [PATCH OSSTEST] sg-report-job-history: alternate color of osstest column only when it changes"):
> On Wed, 2016-01-06 at 11:08 +0000, Ian Campbell wrote:
>
> ping?
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
diff --git a/sg-report-job-history b/sg-report-job-history index 0e2a3f9..e2e5806 100755 --- a/sg-report-job-history +++ b/sg-report-job-history @@ -234,6 +234,7 @@ END my @last_revs; my @alt_revs; my $alt_hosts; + my $alt_osstest; foreach my $r (@test_rows) { my $altcolour= report_altcolour($alternate); print H "<tr $altcolour>"; @@ -254,16 +255,15 @@ END my $hosts_colour = report_altchangecolour(\$alt_hosts, $hosts); print H "<td $hosts_colour>".encode_entities($hosts)."</td>\n"; $osstestverq->execute($r->{Flight}{flight}); - print H - "<td>", - (join ' ', + my $osstestrevs = join ' ', map { $_ = $_->{harness}; s/^([0-9a-f]{12})[0-9a-f]+\b/$1/; "<kbd>".encode_entities($_)."</kbd>"; } - @{ $osstestverq->fetchall_arrayref({}) }), - "</td>\n"; + @{ $osstestverq->fetchall_arrayref({}) }; + my $osstest_colour = report_altchangecolour(\$alt_osstest, $osstestrevs); + print H "<td $osstest_colour>$osstestrevs</td>\n"; foreach my $i (0..$#rev_grid_cols) { my $v= $r->{Revisions}[$i]; my $rev_colour = report_altchangecolour(\$alt_revs[$i], $v);
Currently the bgcolor of the osstest column alternates on each line, rather than only when it changes as the other revision columns do. A given flight might touch multiple osstest revisions (although in practice they rarely do) but it seems reasonable to simply consider any change as a change. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> --- sg-report-job-history | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)