| Message ID | 1452155155-16232-6-git-send-email-wxt@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello Caesar, On 01/07/2016 05:25 AM, Caesar Wang wrote: > This patch adds the exteral vcc optional for the simple power sequence. > > Some WLAN chips attached to a SDIO interface, need an external vcc > to be operational. Since this is very common, extend the simple MMC > power sequence DT binding to support an optional exteral vcc. > s/exteral/external in the subject line and other places. I think that makes sense to extend the simple power sequence provider to add a regulator since many SDIO chips may needed it but it seems from the commit message of patch 06/12 that you don't actually need a regulator but to toggle a WL_REG_ON pin in your WiFi chip. I'll answer to that patch though. Best regards,
diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.txt b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.txt index ce0e767..fdcc6a1 100644 --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.txt +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.txt @@ -12,6 +12,7 @@ Optional properties: at initialization and prior we start the power up procedure of the card. They will be de-asserted right after the power has been provided to the card. +- ext-vcc-supply : Regulator to drive (independent) card VCC. - clocks : Must contain an entry for the entry in clock-names. See ../clocks/clock-bindings.txt for details. - clock-names : Must include the following entry: @@ -19,9 +20,17 @@ Optional properties: Example: + wifi_regulator: wifi-regulator { + compatible = "regulator-fixed"; + enable-active-high; + gpio = <&gpio0 26 GPIO_ACTIVE_HIGH>; + regulator-name = "wifi_regulator"; + }; + sdhci0_pwrseq { compatible = "mmc-pwrseq-simple"; reset-gpios = <&gpio1 12 GPIO_ACTIVE_LOW>; + ext-vcc-supply = <&wifi_regulator>; clocks = <&clk_32768_ck>; clock-names = "ext_clock"; }
This patch adds the exteral vcc optional for the simple power sequence. Some WLAN chips attached to a SDIO interface, need an external vcc to be operational. Since this is very common, extend the simple MMC power sequence DT binding to support an optional exteral vcc. Signed-off-by: Caesar Wang <wxt@rock-chips.com> --- Changes in v2: None Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.txt | 9 +++++++++ 1 file changed, 9 insertions(+)