From patchwork Fri Jan 8 20:36:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 7990211 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 007BBBEEE5 for ; Fri, 8 Jan 2016 20:37:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2F33A201F4 for ; Fri, 8 Jan 2016 20:37:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 4471C201EF for ; Fri, 8 Jan 2016 20:37:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E04357A10D; Fri, 8 Jan 2016 12:37:12 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8E4287A0FF for ; Fri, 8 Jan 2016 12:37:10 -0800 (PST) Received: by mail-wm0-f47.google.com with SMTP id u188so150769731wmu.1 for ; Fri, 08 Jan 2016 12:37:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=YevVndZ/N9Rnm/X20vTDWx1tiNJ3WlHLHozM/748qAY=; b=IqRhhSBh0iFqUODYMS9MErUrbYBrDHLK6X0JRXTiea4BBI3B5qmQgZhaDUrrk/S2xv Y1gx3hqW0YjoztsVUZ0B581kn6B3MkHMnq7/jzyW3/BcSJL5hU3SVGX06bt3i9XTU0cx J/TWfZ0dmFFfb8GAo9nFqsXmTNrN7OTLR1Pbw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=YevVndZ/N9Rnm/X20vTDWx1tiNJ3WlHLHozM/748qAY=; b=WT6xPb81mvvLHTYs0SPub/Uq5fLPEwYKl5sypIHEYKUubS/J34rWXI3qCo+ckhppFP 0Xz1D4VC3q64WDgDGDUZYF6xIAoTQlq9dWif5A1ERVtAyAeY3uDBzUj4DZU5ZMM5vHfN sZMWu1AZZJVdgSQUdtj0FUFKMvW8cM9ptigOheBfox2p/lkLZkL2hijWCBMMq4nPqukQ IardXyt3Xln/HZANarf4Ua4EJj9dCGZG0CLAr5RnoY+gJnDCbgl0KSaUP6erdl6twsaL yK6X/wkS2U8p/jLK3ljDoX8K+8XCzQBsr6Z+Qtwu/DCCfMLxoOXCvd7KuOfjaPpxKIgi x20Q== X-Gm-Message-State: ALoCoQkL+TV8JeCrY9P5bnztjRgKuXUHn6/ZEQpYtG8dJiQ0e+hxLZI7QGDS7q/eEy545RKEXaYzfWLkOjezx/TCngdEP0KWAw== X-Received: by 10.28.158.194 with SMTP id h185mr880271wme.48.1452285429368; Fri, 08 Jan 2016 12:37:09 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by smtp.gmail.com with ESMTPSA id w194sm5679732wmd.0.2016.01.08.12.37.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 08 Jan 2016 12:37:08 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH 12/21] drm/exynos: Remove event cancelling from postclose Date: Fri, 8 Jan 2016 21:36:44 +0100 Message-Id: <1452285413-28459-13-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.6.4 In-Reply-To: <1452285413-28459-1-git-send-email-daniel.vetter@ffwll.ch> References: <1452285413-28459-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Intel Graphics Development , Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The core takes care of this now. And since kfree(NULL) is ok we can simplify the function even further now. Cc: Inki Dae Signed-off-by: Daniel Vetter --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c index 9756797a15a5..868ab9f54f17 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c @@ -335,20 +335,6 @@ static void exynos_drm_preclose(struct drm_device *dev, static void exynos_drm_postclose(struct drm_device *dev, struct drm_file *file) { - struct drm_pending_event *e, *et; - unsigned long flags; - - if (!file->driver_priv) - return; - - spin_lock_irqsave(&dev->event_lock, flags); - /* Release all events handled by page flip handler but not freed. */ - list_for_each_entry_safe(e, et, &file->event_list, link) { - list_del(&e->link); - e->destroy(e); - } - spin_unlock_irqrestore(&dev->event_lock, flags); - kfree(file->driver_priv); file->driver_priv = NULL; }