[v2,1/2] build: introduce CONFIG_NR_CPUS in Kconfig
diff mbox

Message ID 1452549733-13401-1-git-send-email-cardoe@cardoe.com
State New, archived
Headers show

Commit Message

Doug Goldstein Jan. 11, 2016, 10:02 p.m. UTC
Introduce an option where the user can modifiy the maximum number of
supported physical CPUs.

CC: Ian Campbell <ian.campbell@citrix.com>
CC: Stefano Stabellini <stefano.stabellini@citrix.com>
CC: Keir Fraser <keir@xen.org>
CC: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
---
 xen/arch/Kconfig     | 8 ++++++++
 xen/arch/arm/Kconfig | 2 ++
 xen/arch/x86/Kconfig | 2 ++
 3 files changed, 12 insertions(+)
 create mode 100644 xen/arch/Kconfig

Comments

Jan Beulich Jan. 12, 2016, 8:37 a.m. UTC | #1
>>> On 11.01.16 at 23:02, <cardoe@cardoe.com> wrote:
> --- /dev/null
> +++ b/xen/arch/Kconfig
> @@ -0,0 +1,8 @@
> +
> +config NR_CPUS
> +	int "Maximum number of physical CPUs"
> +	range 1 65536

Why did you change this to 64k, when we settled on 4k-1 being
correct? I don't mind fixing this up upon commit, but I'd like it to
be confirmed that this was unintentional.

Jan
Doug Goldstein Jan. 12, 2016, 1:10 p.m. UTC | #2
On 1/12/16 2:37 AM, Jan Beulich wrote:
>>>> On 11.01.16 at 23:02, <cardoe@cardoe.com> wrote:
>> --- /dev/null
>> +++ b/xen/arch/Kconfig
>> @@ -0,0 +1,8 @@
>> +
>> +config NR_CPUS
>> +	int "Maximum number of physical CPUs"
>> +	range 1 65536
> 
> Why did you change this to 64k, when we settled on 4k-1 being
> correct? I don't mind fixing this up upon commit, but I'd like it to
> be confirmed that this was unintentional.
> 
> Jan
> 

It was definitely unintentional. I must have edited the patch to make it
4095 the first time before I sent it.

Patch
diff mbox

diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig
new file mode 100644
index 0000000..aacd73c
--- /dev/null
+++ b/xen/arch/Kconfig
@@ -0,0 +1,8 @@ 
+
+config NR_CPUS
+	int "Maximum number of physical CPUs"
+	range 1 65536
+	default "256" if X86
+	default "128" if ARM
+	---help---
+	  Specifies the maximum number of physical CPUs which Xen will support.
diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index 2cab17b..60e923c 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -31,6 +31,8 @@  config ARCH_DEFCONFIG
 
 menu "Architecture Features"
 
+source "arch/Kconfig"
+
 # Select HAS_GICV3 if GICv3 is supported
 config HAS_GICV3
 	bool
diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
index 7d2ed96..e1c03bb 100644
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -25,6 +25,8 @@  config ARCH_DEFCONFIG
 
 menu "Architecture Features"
 
+source "arch/Kconfig"
+
 endmenu
 
 source "common/Kconfig"