From patchwork Wed Jan 13 14:31:16 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 8026031 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 98F6C9F96D for ; Wed, 13 Jan 2016 14:31:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D0E7C20513 for ; Wed, 13 Jan 2016 14:31:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id A87B82051A for ; Wed, 13 Jan 2016 14:31:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 52BFF6E7A8; Wed, 13 Jan 2016 06:31:21 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by gabe.freedesktop.org (Postfix) with ESMTPS id D49FD6E7A8 for ; Wed, 13 Jan 2016 06:31:19 -0800 (PST) Received: by mail-wm0-f53.google.com with SMTP id f206so298118677wmf.0 for ; Wed, 13 Jan 2016 06:31:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id; bh=LM6g+K2g5d9XrRaHvSssSgTpa4bV/D4ORgTOa6e1ivc=; b=atQ2ifKtjKPZuueS1OLgSOzTP3rwLEbjnHYe8BsdvzJMIsur4CBLlwoyipyUt95DCl q+WKUkZ1+UIfuYdaAO2BCEcATga2Be70Nn635PYlaPBJbmgyXkfFZvNljN70dYSa6q5K ++q/DRMiUygSkdVuGqrTfE4OYKX6j9srejZ88= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=LM6g+K2g5d9XrRaHvSssSgTpa4bV/D4ORgTOa6e1ivc=; b=msWKdT0FKHVq+a5paZ3kxaqxcNFG6OSh6VFVaO57uQLFnuVMxFg0DFqfAKsbFIdQFK xfbJjDGJLX20r0ICXE65BvkKEkKD0dG3MH34RyeXFEriwYBZtjS+a3xyMEKX48KxrYF8 K02bY32M1nXyIMncwtYBARvKSQSP/5kAYZLyPr8I/btYARLwfkS2g6yRhlJXXp5oEfbK k2iUVT5m7hfoZV4fpya/m1jDIYaQUcuZrC7Bbcw+cxakcXNBgdsXJ2dZDxdFvwYX9iqC TroLBZLhI96XswqKQv5/SBqB5FtcZOYx7GsoEEmSxF+6c6adwa7hPxi/tZDCfM1glPL/ q2UA== X-Gm-Message-State: ALoCoQk0FfNiFrJY0WdhAEBk5Vnan7iy1T23lD1aTG2tj+h5b4MGkz/lQE7+9B2LLParO+RKmUYwvUlFBMdy3IAPD3Wc58czKw== X-Received: by 10.28.129.202 with SMTP id c193mr25202777wmd.35.1452695478281; Wed, 13 Jan 2016 06:31:18 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:56c9:0:22cf:30ff:fe4c:37d6]) by smtp.gmail.com with ESMTPSA id ha9sm1729976wjc.3.2016.01.13.06.31.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 13 Jan 2016 06:31:17 -0800 (PST) From: Daniel Vetter To: Intel Graphics Development Subject: [PATCH] drm/crtc-helper: Add caveat to disable_unused_functions doc Date: Wed, 13 Jan 2016 15:31:16 +0100 Message-Id: <1452695476-31147-1-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.7.0.rc3 Cc: Daniel Vetter , Maxime Ripard , Laurent Pinchart , DRI Development , Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This shouldn't be used by atomic drivers any more, it confuses the state tracking. Cc: Maxime Ripard Cc: Laurent Pinchart Acked-by: Laurent Pinchart Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_crtc_helper.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c index a02a7f9a6a9d..a278fbbe23e0 100644 --- a/drivers/gpu/drm/drm_crtc_helper.c +++ b/drivers/gpu/drm/drm_crtc_helper.c @@ -220,6 +220,15 @@ static void __drm_helper_disable_unused_functions(struct drm_device *dev) * disconnected connectors. Then it will disable all unused encoders and CRTCs * either by calling their disable callback if available or by calling their * dpms callback with DRM_MODE_DPMS_OFF. + * + * NOTE: + * + * This function is part of the legacy modeset helper library and will cause + * major confusion with atomic drivers. This is because atomic helpers guarantee + * to never call ->disable() hooks on a disabled function, or ->enable() hooks + * on an enabled functions. drm_helper_disable_unused_functions() on the other + * hand throws such guarantees into the wind and calls disable hooks + * unconditionally on unused functions. */ void drm_helper_disable_unused_functions(struct drm_device *dev) {