diff mbox

[v4,3/5] tools/libxc: don't send end record if remus fails

Message ID 1453095622-14859-4-git-send-email-wency@cn.fujitsu.com (mailing list archive)
State New, archived
Headers show

Commit Message

Wen Congyang Jan. 18, 2016, 5:40 a.m. UTC 
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
 tools/libxc/xc_sr_save.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ian Campbell Jan. 18, 2016, 4:53 p.m. UTC | #1 
On Mon, 2016-01-18 at 13:40 +0800, Wen Congyang wrote:
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

What was the outcoming of Andy's comment on v1 regarding error handling for
->postcopy?

> ---
>  tools/libxc/xc_sr_save.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/libxc/xc_sr_save.c b/tools/libxc/xc_sr_save.c
> index 88d85ef..e532168 100644
> --- a/tools/libxc/xc_sr_save.c
> +++ b/tools/libxc/xc_sr_save.c
> @@ -795,7 +795,7 @@ static int save(struct xc_sr_context *ctx, uint16_t
> guest_type)
>  
>              rc = ctx->save.callbacks->checkpoint(ctx->save.callbacks-
> >data);
>              if ( rc <= 0 )
> -                ctx->save.checkpointed = false;
> +                goto err;
>          }
>      } while ( ctx->save.checkpointed );
>
Ian Campbell Jan. 18, 2016, 4:53 p.m. UTC | #2 
On Mon, 2016-01-18 at 16:53 +0000, Ian Campbell wrote:
> 
> What was the outcoming of Andy's comment on v1 regarding error handling
> for ->postcopy?

Ignore this, I saw just too late that it was in #4.

Ian.
diff mbox

Patch

diff --git a/tools/libxc/xc_sr_save.c b/tools/libxc/xc_sr_save.c
index 88d85ef..e532168 100644
--- a/tools/libxc/xc_sr_save.c
+++ b/tools/libxc/xc_sr_save.c
@@ -795,7 +795,7 @@  static int save(struct xc_sr_context *ctx, uint16_t guest_type)
 
             rc = ctx->save.callbacks->checkpoint(ctx->save.callbacks->data);
             if ( rc <= 0 )
-                ctx->save.checkpointed = false;
+                goto err;
         }
     } while ( ctx->save.checkpointed );