diff mbox

[OSSTEST,v2,02/12] target_var: Support fallback to all_(guest|host)_$vn

Message ID 1453127337-16136-2-git-send-email-ian.campbell@citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ian Campbell Jan. 18, 2016, 2:28 p.m. UTC
Having to set {ident}_foo for all idents used in a job (e.g host vs
src_host+dst_host) in make-flight would be a little fiddly.

Instead follow the lead of all_hostflags and consult all_host_$vn.

I have no immediate use for all_guest_$vn, but support it for
consistency.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
 Osstest/TestSupport.pm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff mbox

Patch

diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index 9a90c2e..7251344 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -2091,7 +2091,10 @@  sub target_var_prefix ($) {
 
 sub target_var ($$) {
     my ($ho,$vn) = @_;
-    return $r{ target_var_prefix($ho). $vn };
+    my $pfx = target_var_prefix($ho);
+    my $allthing = exists $ho->{Guest} ? "guest" : "host";
+    return $r{ $pfx. $vn } //
+           $r{ "all_${allthing}_${vn}" };
 }
 
 sub target_kernkind_check ($) {