| Message ID | 1453270097-53853-4-git-send-email-jamesjj.liao@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 2016-01-20 at 14:08 +0800, James Liao wrote: > From: Shunli Wang <shunli.wang@mediatek.com> > > Add power dt-bindings for MT2701. > > Signed-off-by: Shunli Wang <shunli.wang@mediatek.com> > Signed-off-by: James Liao <jamesjj.liao@mediatek.com> > --- > .../devicetree/bindings/soc/mediatek/scpsys.txt | 6 +++-- > include/dt-bindings/power/mt2701-power.h | 27 ++++++++++++++++++++++ > 2 files changed, 31 insertions(+), 2 deletions(-) > create mode 100644 include/dt-bindings/power/mt2701-power.h > > diff --git a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > index a6c8afc..807d87f 100644 > --- a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > +++ b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > @@ -9,10 +9,12 @@ domain control. > > The driver implements the Generic PM domain bindings described in > power/power_domain.txt. It provides the power domains defined in > -include/dt-bindings/power/mt8173-power.h. > +include/dt-bindings/power/mt8173-power.h and mt2701-power.h. > > Required properties: > -- compatible: Must be "mediatek,mt8173-scpsys" > +- compatible: Should be: > + - "mediatek,mt8173-scpsys" > + - "mediatek,mt2701-scpsys" > - #power-domain-cells: Must be 1 > - reg: Address range of the SCPSYS unit > - infracfg: must contain a phandle to the infracfg controller Please sort the list. Joe.C
On Wed, Jan 20, 2016 at 05:29:21PM +0800, Yingjoe Chen wrote: > On Wed, 2016-01-20 at 14:08 +0800, James Liao wrote: > > From: Shunli Wang <shunli.wang@mediatek.com> > > > > Add power dt-bindings for MT2701. > > > > Signed-off-by: Shunli Wang <shunli.wang@mediatek.com> > > Signed-off-by: James Liao <jamesjj.liao@mediatek.com> > > --- > > .../devicetree/bindings/soc/mediatek/scpsys.txt | 6 +++-- > > include/dt-bindings/power/mt2701-power.h | 27 ++++++++++++++++++++++ > > 2 files changed, 31 insertions(+), 2 deletions(-) > > create mode 100644 include/dt-bindings/power/mt2701-power.h > > > > diff --git a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > > index a6c8afc..807d87f 100644 > > --- a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > > +++ b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > > @@ -9,10 +9,12 @@ domain control. > > > > The driver implements the Generic PM domain bindings described in > > power/power_domain.txt. It provides the power domains defined in > > -include/dt-bindings/power/mt8173-power.h. > > +include/dt-bindings/power/mt8173-power.h and mt2701-power.h. > > > > Required properties: > > -- compatible: Must be "mediatek,mt8173-scpsys" > > +- compatible: Should be: > > + - "mediatek,mt8173-scpsys" > > + - "mediatek,mt2701-scpsys" > > - #power-domain-cells: Must be 1 > > - reg: Address range of the SCPSYS unit > > - infracfg: must contain a phandle to the infracfg controller > > Please sort the list. And s/Should be/Should be one of/ Rob
Hi Yingjoe, Rob, On Wed, 2016-01-20 at 10:35 -0600, Rob Herring wrote: > On Wed, Jan 20, 2016 at 05:29:21PM +0800, Yingjoe Chen wrote: > > On Wed, 2016-01-20 at 14:08 +0800, James Liao wrote: > > > From: Shunli Wang <shunli.wang@mediatek.com> > > > > > > Add power dt-bindings for MT2701. > > > > > > Signed-off-by: Shunli Wang <shunli.wang@mediatek.com> > > > Signed-off-by: James Liao <jamesjj.liao@mediatek.com> > > > --- > > > .../devicetree/bindings/soc/mediatek/scpsys.txt | 6 +++-- > > > include/dt-bindings/power/mt2701-power.h | 27 ++++++++++++++++++++++ > > > 2 files changed, 31 insertions(+), 2 deletions(-) > > > create mode 100644 include/dt-bindings/power/mt2701-power.h > > > > > > diff --git a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > > > index a6c8afc..807d87f 100644 > > > --- a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > > > +++ b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > > > @@ -9,10 +9,12 @@ domain control. > > > > > > The driver implements the Generic PM domain bindings described in > > > power/power_domain.txt. It provides the power domains defined in > > > -include/dt-bindings/power/mt8173-power.h. > > > +include/dt-bindings/power/mt8173-power.h and mt2701-power.h. > > > > > > Required properties: > > > -- compatible: Must be "mediatek,mt8173-scpsys" > > > +- compatible: Should be: > > > + - "mediatek,mt8173-scpsys" > > > + - "mediatek,mt2701-scpsys" > > > - #power-domain-cells: Must be 1 > > > - reg: Address range of the SCPSYS unit > > > - infracfg: must contain a phandle to the infracfg controller > > > > Please sort the list. > > And s/Should be/Should be one of/ OK. I'll modify it in next patch. Best regards, James
diff --git a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt index a6c8afc..807d87f 100644 --- a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt +++ b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt @@ -9,10 +9,12 @@ domain control. The driver implements the Generic PM domain bindings described in power/power_domain.txt. It provides the power domains defined in -include/dt-bindings/power/mt8173-power.h. +include/dt-bindings/power/mt8173-power.h and mt2701-power.h. Required properties: -- compatible: Must be "mediatek,mt8173-scpsys" +- compatible: Should be: + - "mediatek,mt8173-scpsys" + - "mediatek,mt2701-scpsys" - #power-domain-cells: Must be 1 - reg: Address range of the SCPSYS unit - infracfg: must contain a phandle to the infracfg controller diff --git a/include/dt-bindings/power/mt2701-power.h b/include/dt-bindings/power/mt2701-power.h new file mode 100644 index 0000000..64cc826 --- /dev/null +++ b/include/dt-bindings/power/mt2701-power.h @@ -0,0 +1,27 @@ +/* + * Copyright (C) 2015 MediaTek Inc. + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef _DT_BINDINGS_POWER_MT2701_POWER_H +#define _DT_BINDINGS_POWER_MT2701_POWER_H + +#define MT2701_POWER_DOMAIN_CONN 0 +#define MT2701_POWER_DOMAIN_DISP 1 +#define MT2701_POWER_DOMAIN_MFG 2 +#define MT2701_POWER_DOMAIN_VDEC 3 +#define MT2701_POWER_DOMAIN_ISP 4 +#define MT2701_POWER_DOMAIN_BDP 5 +#define MT2701_POWER_DOMAIN_ETH 6 +#define MT2701_POWER_DOMAIN_HIF 7 +#define MT2701_POWER_DOMAIN_IFR_MSC 8 + +#endif /* _DT_BINDINGS_POWER_MT2701_POWER_H */