[v5,20/38] pnfs: per mount layout driver private data
diff mbox

Message ID 1306108649-28644-1-git-send-email-bhalevy@panasas.com
State New, archived
Headers show

Commit Message

Benny Halevy May 22, 2011, 11:57 p.m. UTC
With the objects layout security model we have object capabilities
that are associated with the layout ad we anticipate that the server
will issue a cb_layoutrecall for any setattr that changes security
related attributes (user/group/mode/acl) or truncates the file.
Therefore, the client returns the layout in advance to avoid the
extra layout recall.

[get rid of ds_[rw]size]
Signed-off-by: Benny Halevy <bhalevy@panasas.com>
---
 include/linux/nfs_fs_sb.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Boaz Harrosh May 23, 2011, 4:38 a.m. UTC | #1
On 05/23/2011 02:57 AM, Benny Halevy wrote:
> With the objects layout security model we have object capabilities
> that are associated with the layout ad we anticipate that the server
> will issue a cb_layoutrecall for any setattr that changes security
> related attributes (user/group/mode/acl) or truncates the file.
> Therefore, the client returns the layout in advance to avoid the
> extra layout recall.
> 

This looks like the wrong text. It belongs to that other patch.

The title and actual patch do match

Boaz
> [get rid of ds_[rw]size]
> Signed-off-by: Benny Halevy <bhalevy@panasas.com>
> ---
>  include/linux/nfs_fs_sb.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/nfs_fs_sb.h b/include/linux/nfs_fs_sb.h
> index 87694ca..66e031f 100644
> --- a/include/linux/nfs_fs_sb.h
> +++ b/include/linux/nfs_fs_sb.h
> @@ -143,6 +143,7 @@ struct nfs_server {
>  						   filesystem */
>  	struct pnfs_layoutdriver_type  *pnfs_curr_ld; /* Active layout driver */
>  	struct rpc_wait_queue	roc_rpcwaitq;
> +	void			       *pnfs_ld_data; /* Per-mount data */
>  
>  	/* the following fields are protected by nfs_client->cl_lock */
>  	struct rb_root		state_owners;

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Benny Halevy May 23, 2011, 1:36 p.m. UTC | #2
On 2011-05-23 07:38, Boaz Harrosh wrote:
> On 05/23/2011 02:57 AM, Benny Halevy wrote:
>> With the objects layout security model we have object capabilities
>> that are associated with the layout ad we anticipate that the server
>> will issue a cb_layoutrecall for any setattr that changes security
>> related attributes (user/group/mode/acl) or truncates the file.
>> Therefore, the client returns the layout in advance to avoid the
>> extra layout recall.
>>
> 
> This looks like the wrong text. It belongs to that other patch.

Hmm, looks like a pilot error... thanks!

Benny

> 
> The title and actual patch do match
> 
> Boaz
>> [get rid of ds_[rw]size]
>> Signed-off-by: Benny Halevy <bhalevy@panasas.com>
>> ---
>>  include/linux/nfs_fs_sb.h |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/linux/nfs_fs_sb.h b/include/linux/nfs_fs_sb.h
>> index 87694ca..66e031f 100644
>> --- a/include/linux/nfs_fs_sb.h
>> +++ b/include/linux/nfs_fs_sb.h
>> @@ -143,6 +143,7 @@ struct nfs_server {
>>  						   filesystem */
>>  	struct pnfs_layoutdriver_type  *pnfs_curr_ld; /* Active layout driver */
>>  	struct rpc_wait_queue	roc_rpcwaitq;
>> +	void			       *pnfs_ld_data; /* Per-mount data */
>>  
>>  	/* the following fields are protected by nfs_client->cl_lock */
>>  	struct rb_root		state_owners;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/include/linux/nfs_fs_sb.h b/include/linux/nfs_fs_sb.h
index 87694ca..66e031f 100644
--- a/include/linux/nfs_fs_sb.h
+++ b/include/linux/nfs_fs_sb.h
@@ -143,6 +143,7 @@  struct nfs_server {
 						   filesystem */
 	struct pnfs_layoutdriver_type  *pnfs_curr_ld; /* Active layout driver */
 	struct rpc_wait_queue	roc_rpcwaitq;
+	void			       *pnfs_ld_data; /* Per-mount data */
 
 	/* the following fields are protected by nfs_client->cl_lock */
 	struct rb_root		state_owners;