From patchwork Thu Jan 21 05:04:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 8077481 Return-Path: X-Original-To: patchwork-linux-rockchip@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 45D69BEEE5 for ; Thu, 21 Jan 2016 05:05:34 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 50A7E205DC for ; Thu, 21 Jan 2016 05:05:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8927F205DA for ; Thu, 21 Jan 2016 05:05:32 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aM7R6-0000dw-7I; Thu, 21 Jan 2016 05:05:32 +0000 Received: from mail-pa0-x22a.google.com ([2607:f8b0:400e:c03::22a]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aM7Qz-0000Q9-VQ for linux-rockchip@lists.infradead.org; Thu, 21 Jan 2016 05:05:27 +0000 Received: by mail-pa0-x22a.google.com with SMTP id yy13so16633531pab.3 for ; Wed, 20 Jan 2016 21:05:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=JQVVu/sHKAKMqmz5+50qZBx3Tw5NfYl7M1QpgUZpAKM=; b=XKz6WFDQ55uQdEMjO5iB49W1WlpcwUYfy7GfBnbaabYdAOuYmY3hgDEyQGDx90ZxlE E30Q9KC5toZf4Ka9GBDCQMvIpFXtoUxiVeAp+ai9hzjO2NT16YSGw5Sl0EZj4nNgGZpM Q4hSdEmIH/1d0Vmoz+nCAN7oEIQOl59bzEtck= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=JQVVu/sHKAKMqmz5+50qZBx3Tw5NfYl7M1QpgUZpAKM=; b=MfsWcNF5vU5WW/oJDsBahkaGy+/lQ3lYFfN8iIKRXtPm6B0ndca++qPsxUcOBH6eUM L22Hno9U9CJc33b70Xjh3eVDMgOxw0hVlCl1jU7ITezxSjOTLlqNURtb20kMraIDwfZD 5p1lhEzBno/tbFXslVtdb/nrI/USLlNb19EbfuMF7LFV4u7ddKxLNCMjM+qW6+Riafio 9lquWs/Zit8lGcmylqOHcChYwnlbdaYbCLirIFFLOJP3LxWsWxohPnHjC8NpiasCwcS9 6kN4b+DdjPOKjpRKZMIbnXNajxmymzROB0bdxZStoyFKWkGZdy1+2P8KpZj6rFBr3Wl8 4y8A== X-Gm-Message-State: ALoCoQmVolMJGvX+i0czuggfThYfLGZGDzJ0WsAqMy3xcJ/uS8YB0W9lSsqORKY0/qtyD/3zNhYYol58P16Ndx+zb5MAHAG6tg== X-Received: by 10.67.4.100 with SMTP id cd4mr58432278pad.59.1453352705290; Wed, 20 Jan 2016 21:05:05 -0800 (PST) Received: from tictac.mtv.corp.google.com ([172.22.65.76]) by smtp.gmail.com with ESMTPSA id z28sm52255589pfi.19.2016.01.20.21.05.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 20 Jan 2016 21:05:04 -0800 (PST) From: Douglas Anderson To: John Youn , balbi@ti.com, kever.yang@rock-chips.com Subject: [PATCH v4 03/21] usb: dwc2: host: Set host_rx_fifo_size to 528 for rk3066 Date: Wed, 20 Jan 2016 21:04:14 -0800 Message-Id: <1453352672-27890-4-git-send-email-dianders@chromium.org> X-Mailer: git-send-email 2.7.0.rc3.207.g0ac5344 In-Reply-To: <1453352672-27890-1-git-send-email-dianders@chromium.org> References: <1453352672-27890-1-git-send-email-dianders@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160120_210526_146079_BD7B63BB X-CRM114-Status: GOOD ( 14.03 ) X-Spam-Score: -2.7 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gregory.herrero@intel.com, =?UTF-8?q?Heiko=20St=C3=BCbner?= , johnyoun@synopsys.com, gregkh@linuxfoundation.org, ming.lei@canonical.com, linux-usb@vger.kernel.org, Douglas Anderson , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, yousaf.kaukab@intel.com, stern@rowland.harvard.edu, Julius Werner , dinguyen@opensource.altera.com MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As documented in dwc2_calculate_dynamic_fifo(), host_rx_fifo_size should really be: 2 * ((Largest Packet size / 4) + 1 + 1) + n with n = number of host channel. We have 9 host channels, so 2 * ((1024/4) + 2) + 9 = 516 + 9 = 525 We've got 960 / 972 total_fifo_size on rk3288 (and presumably on rk3066) and 525 + 128 + 256 = 909 so we're still under on both ports even when we increment by 5. Since we have space, Kever Yang suggests bumping by 8. He says this will meet INCR16 access and next fifo type can start with a aligned address. ...so let's bump up by 8. In the future, it would be nice if dwc2_calculate_dynamic_fifo() could handle the "too small" FIFO case and come up with something more dynamically. When we do that we can figure out how to allocate the extra 48 / 60 bytes of FIFO that we're currently wasting. NOTE: no known bugs are fixed by this patch, but it seems like a simple fix and ought to fix someone. Signed-off-by: Douglas Anderson --- Changes in v4: - Set host_rx_fifo_size to 528 for rk3066 new for v4. Changes in v3: None Changes in v2: None drivers/usb/dwc2/platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c index 5008a467ce06..b6d7666e715c 100644 --- a/drivers/usb/dwc2/platform.c +++ b/drivers/usb/dwc2/platform.c @@ -126,7 +126,7 @@ static const struct dwc2_core_params params_rk3066 = { .speed = -1, .enable_dynamic_fifo = 1, .en_multiple_tx_fifo = -1, - .host_rx_fifo_size = 520, /* 520 DWORDs */ + .host_rx_fifo_size = 528, /* 528 DWORDs */ .host_nperio_tx_fifo_size = 128, /* 128 DWORDs */ .host_perio_tx_fifo_size = 256, /* 256 DWORDs */ .max_transfer_size = -1,