From patchwork Thu Jan 21 10:26:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chandan Rajendra X-Patchwork-Id: 8079921 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 862B0BEEE5 for ; Thu, 21 Jan 2016 10:29:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 478D520557 for ; Thu, 21 Jan 2016 10:29:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B045220558 for ; Thu, 21 Jan 2016 10:29:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935334AbcAUK3Z (ORCPT ); Thu, 21 Jan 2016 05:29:25 -0500 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:55786 "EHLO e23smtp01.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935132AbcAUK21 (ORCPT ); Thu, 21 Jan 2016 05:28:27 -0500 Received: from localhost by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 21 Jan 2016 20:28:25 +1000 Received: from d23dlp01.au.ibm.com (202.81.31.203) by e23smtp01.au.ibm.com (202.81.31.207) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 21 Jan 2016 20:28:23 +1000 X-IBM-Helo: d23dlp01.au.ibm.com X-IBM-MailFrom: chandan@linux.vnet.ibm.com X-IBM-RcptTo: linux-btrfs@vger.kernel.org Received: from d23relay09.au.ibm.com (d23relay09.au.ibm.com [9.185.63.181]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 4DC8B2CE8055 for ; Thu, 21 Jan 2016 21:28:23 +1100 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay09.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u0LASFc42162966 for ; Thu, 21 Jan 2016 21:28:23 +1100 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u0LARodV026352 for ; Thu, 21 Jan 2016 21:27:50 +1100 Received: from localhost.in.ibm.com ([9.79.211.32]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u0LARN3p024796; Thu, 21 Jan 2016 21:27:48 +1100 From: Chandan Rajendra To: linux-btrfs@vger.kernel.org Cc: Chandan Rajendra , jbacik@fb.com, clm@fb.com, bo.li.liu@oracle.com, dsterba@suse.cz, chandan@mykolab.com Subject: [PATCH V13 11/14] Btrfs: subpagesize-blocksize: Prevent writes to an extent buffer when PG_writeback flag is set. Date: Thu, 21 Jan 2016 15:56:58 +0530 Message-Id: <1453372021-5089-12-git-send-email-chandan@linux.vnet.ibm.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1453372021-5089-1-git-send-email-chandan@linux.vnet.ibm.com> References: <1453372021-5089-1-git-send-email-chandan@linux.vnet.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16012110-1618-0000-0000-000003889F5B Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In non-subpagesize-blocksize scenario, BTRFS_HEADER_FLAG_WRITTEN flag prevents Btrfs code from writing into an extent buffer whose pages are under writeback. This facility isn't sufficient for achieving the same in subpagesize-blocksize scenario, since we have more than one extent buffer mapped to a page. Hence this patch adds a new flag (i.e. EXTENT_BUFFER_HEAD_WRITEBACK) and corresponding code to track the writeback status of the page and to prevent writes to any of the extent buffers mapped to the page while writeback is going on. Signed-off-by: Chandan Rajendra --- fs/btrfs/ctree.c | 21 ++++++- fs/btrfs/extent-tree.c | 11 ++++ fs/btrfs/extent_io.c | 150 ++++++++++++++++++++++++++++++++++++++++--------- fs/btrfs/extent_io.h | 1 + 4 files changed, 155 insertions(+), 28 deletions(-) diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c index c3907b3..6afb6b8 100644 --- a/fs/btrfs/ctree.c +++ b/fs/btrfs/ctree.c @@ -1538,6 +1538,7 @@ noinline int btrfs_cow_block(struct btrfs_trans_handle *trans, struct extent_buffer *parent, int parent_slot, struct extent_buffer **cow_ret) { + struct extent_buffer_head *ebh = eb_head(buf); u64 search_start; int ret; @@ -1551,6 +1552,14 @@ noinline int btrfs_cow_block(struct btrfs_trans_handle *trans, trans->transid, root->fs_info->generation); if (!should_cow_block(trans, root, buf)) { + if (test_bit(EXTENT_BUFFER_HEAD_WRITEBACK, &ebh->bflags)) { + if (parent) + btrfs_set_lock_blocking(parent); + btrfs_set_lock_blocking(buf); + wait_on_bit_io(&ebh->bflags, + EXTENT_BUFFER_HEAD_WRITEBACK, + TASK_UNINTERRUPTIBLE); + } *cow_ret = buf; return 0; } @@ -2671,6 +2680,7 @@ int btrfs_search_slot(struct btrfs_trans_handle *trans, struct btrfs_root *root, struct btrfs_key *key, struct btrfs_path *p, int ins_len, int cow) { + struct extent_buffer_head *ebh; struct extent_buffer *b; int slot; int ret; @@ -2773,8 +2783,17 @@ again: * then we don't want to set the path blocking, * so we test it here */ - if (!should_cow_block(trans, root, b)) + if (!should_cow_block(trans, root, b)) { + ebh = eb_head(b); + if (test_bit(EXTENT_BUFFER_HEAD_WRITEBACK, + &ebh->bflags)) { + btrfs_set_path_blocking(p); + wait_on_bit_io(&ebh->bflags, + EXTENT_BUFFER_HEAD_WRITEBACK, + TASK_UNINTERRUPTIBLE); + } goto cow_done; + } /* * must have write locks on this node and the diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index d76c77c..b811692 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -7873,14 +7873,25 @@ static struct extent_buffer * btrfs_init_new_buffer(struct btrfs_trans_handle *trans, struct btrfs_root *root, u64 bytenr, int level) { + struct extent_buffer_head *ebh; struct extent_buffer *buf; buf = btrfs_find_create_tree_block(root, bytenr); if (!buf) return ERR_PTR(-ENOMEM); + + ebh = eb_head(buf); btrfs_set_header_generation(buf, trans->transid); btrfs_set_buffer_lockdep_class(root->root_key.objectid, buf, level); btrfs_tree_lock(buf); + + if (test_bit(EXTENT_BUFFER_HEAD_WRITEBACK, + &ebh->bflags)) { + btrfs_set_lock_blocking(buf); + wait_on_bit_io(&ebh->bflags, EXTENT_BUFFER_HEAD_WRITEBACK, + TASK_UNINTERRUPTIBLE); + } + clean_tree_block(trans, root->fs_info, buf); clear_bit(EXTENT_BUFFER_STALE, &buf->ebflags); diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index acf855c..50326ca 100644 --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c @@ -3702,6 +3702,52 @@ void wait_on_extent_buffer_writeback(struct extent_buffer *eb) TASK_UNINTERRUPTIBLE); } +static void lock_extent_buffers(struct extent_buffer_head *ebh, + struct extent_page_data *epd) +{ + struct extent_buffer *locked_eb = NULL; + struct extent_buffer *eb; +again: + eb = &ebh->eb; + do { + if (eb == locked_eb) + continue; + + if (!btrfs_try_tree_write_lock(eb)) + goto backoff; + + } while ((eb = eb->eb_next) != NULL); + + return; + +backoff: + if (locked_eb && (locked_eb->start > eb->start)) + btrfs_tree_unlock(locked_eb); + + locked_eb = eb; + + eb = &ebh->eb; + while (eb != locked_eb) { + btrfs_tree_unlock(eb); + eb = eb->eb_next; + } + + flush_write_bio(epd); + + btrfs_tree_lock(locked_eb); + + goto again; +} + +static void unlock_extent_buffers(struct extent_buffer_head *ebh) +{ + struct extent_buffer *eb = &ebh->eb; + + do { + btrfs_tree_unlock(eb); + } while ((eb = eb->eb_next) != NULL); +} + static void lock_extent_buffer_pages(struct extent_buffer_head *ebh, struct extent_page_data *epd) { @@ -3721,21 +3767,17 @@ static void lock_extent_buffer_pages(struct extent_buffer_head *ebh, } static int noinline_for_stack -lock_extent_buffer_for_io(struct extent_buffer *eb, +mark_extent_buffer_writeback(struct extent_buffer *eb, struct btrfs_fs_info *fs_info, struct extent_page_data *epd) { + struct extent_buffer_head *ebh = eb_head(eb); + struct extent_buffer *cur; int dirty; int ret = 0; - if (!btrfs_try_tree_write_lock(eb)) { - flush_write_bio(epd); - btrfs_tree_lock(eb); - } - if (test_bit(EXTENT_BUFFER_WRITEBACK, &eb->ebflags)) { dirty = test_bit(EXTENT_BUFFER_DIRTY, &eb->ebflags); - btrfs_tree_unlock(eb); if (!epd->sync_io) { if (!dirty) return 1; @@ -3743,15 +3785,23 @@ lock_extent_buffer_for_io(struct extent_buffer *eb, return 2; } + cur = &ebh->eb; + do { + btrfs_set_lock_blocking(cur); + } while ((cur = cur->eb_next) != NULL); + flush_write_bio(epd); while (1) { wait_on_extent_buffer_writeback(eb); - btrfs_tree_lock(eb); if (!test_bit(EXTENT_BUFFER_WRITEBACK, &eb->ebflags)) break; - btrfs_tree_unlock(eb); } + + cur = &ebh->eb; + do { + btrfs_clear_lock_blocking(cur); + } while ((cur = cur->eb_next) != NULL); } /* @@ -3759,22 +3809,20 @@ lock_extent_buffer_for_io(struct extent_buffer *eb, * under IO since we can end up having no IO bits set for a short period * of time. */ - spin_lock(&eb_head(eb)->refs_lock); + spin_lock(&ebh->refs_lock); if (test_and_clear_bit(EXTENT_BUFFER_DIRTY, &eb->ebflags)) { set_bit(EXTENT_BUFFER_WRITEBACK, &eb->ebflags); - spin_unlock(&eb_head(eb)->refs_lock); + spin_unlock(&ebh->refs_lock); btrfs_set_header_flag(eb, BTRFS_HEADER_FLAG_WRITTEN); __percpu_counter_add(&fs_info->dirty_metadata_bytes, -eb->len, fs_info->dirty_metadata_batch); ret = 0; } else { - spin_unlock(&eb_head(eb)->refs_lock); + spin_unlock(&ebh->refs_lock); ret = 1; } - btrfs_tree_unlock(eb); - return ret; } @@ -3918,8 +3966,8 @@ static void set_btree_ioerr(struct extent_buffer *eb, struct page *page) static void end_bio_subpagesize_blocksize_ebh_writepage(struct bio *bio) { - struct bio_vec *bvec; struct extent_buffer *eb; + struct bio_vec *bvec; int i, done; bio_for_each_segment_all(bvec, bio, i) { @@ -3951,6 +3999,15 @@ static void end_bio_subpagesize_blocksize_ebh_writepage(struct bio *bio) end_extent_buffer_writeback(eb); + if (done) { + struct extent_buffer_head *ebh = eb_head(eb); + + clear_bit(EXTENT_BUFFER_HEAD_WRITEBACK, + &ebh->bflags); + smp_mb__after_atomic(); + wake_up_bit(&ebh->bflags, + EXTENT_BUFFER_HEAD_WRITEBACK); + } } while ((eb = eb->eb_next) != NULL); } @@ -3960,6 +4017,7 @@ static void end_bio_subpagesize_blocksize_ebh_writepage(struct bio *bio) static void end_bio_regular_ebh_writepage(struct bio *bio) { + struct extent_buffer_head *ebh; struct extent_buffer *eb; struct bio_vec *bvec; int i, done; @@ -3970,7 +4028,9 @@ static void end_bio_regular_ebh_writepage(struct bio *bio) eb = (struct extent_buffer *)page->private; BUG_ON(!eb); - done = atomic_dec_and_test(&eb_head(eb)->io_bvecs); + ebh = eb_head(eb); + + done = atomic_dec_and_test(&ebh->io_bvecs); if (bio->bi_error || test_bit(EXTENT_BUFFER_WRITE_ERR, &eb->ebflags)) { @@ -3984,6 +4044,10 @@ static void end_bio_regular_ebh_writepage(struct bio *bio) continue; end_extent_buffer_writeback(eb); + + clear_bit(EXTENT_BUFFER_HEAD_WRITEBACK, &ebh->bflags); + smp_mb__after_atomic(); + wake_up_bit(&ebh->bflags, EXTENT_BUFFER_HEAD_WRITEBACK); } bio_put(bio); @@ -4025,8 +4089,14 @@ write_regular_ebh(struct extent_buffer_head *ebh, set_btree_ioerr(eb, p); end_page_writeback(p); if (atomic_sub_and_test(num_pages - i, - &eb_head(eb)->io_bvecs)) + &ebh->io_bvecs)) { end_extent_buffer_writeback(eb); + clear_bit(EXTENT_BUFFER_HEAD_WRITEBACK, + &ebh->bflags); + smp_mb__after_atomic(); + wake_up_bit(&ebh->bflags, + EXTENT_BUFFER_HEAD_WRITEBACK); + } ret = -EIO; break; } @@ -4060,6 +4130,7 @@ static int write_subpagesize_blocksize_ebh(struct extent_buffer_head *ebh, unsigned long i; unsigned long bio_flags = 0; int rw = (epd->sync_io ? WRITE_SYNC : WRITE) | REQ_META; + int nr_eb_submitted = 0; int ret = 0, err = 0; eb = &ebh->eb; @@ -4072,7 +4143,7 @@ static int write_subpagesize_blocksize_ebh(struct extent_buffer_head *ebh, continue; clear_bit(EXTENT_BUFFER_WRITE_ERR, &eb->ebflags); - atomic_inc(&eb_head(eb)->io_bvecs); + atomic_inc(&ebh->io_bvecs); if (btrfs_header_owner(eb) == BTRFS_TREE_LOG_OBJECTID) bio_flags = EXTENT_BIO_TREE_LOG; @@ -4090,6 +4161,8 @@ static int write_subpagesize_blocksize_ebh(struct extent_buffer_head *ebh, atomic_dec(&eb_head(eb)->io_bvecs); end_extent_buffer_writeback(eb); err = -EIO; + } else { + ++nr_eb_submitted; } } while ((eb = eb->eb_next) != NULL); @@ -4097,6 +4170,12 @@ static int write_subpagesize_blocksize_ebh(struct extent_buffer_head *ebh, update_nr_written(p, wbc, 1); } + if (!nr_eb_submitted) { + clear_bit(EXTENT_BUFFER_HEAD_WRITEBACK, &ebh->bflags); + smp_mb__after_atomic(); + wake_up_bit(&ebh->bflags, EXTENT_BUFFER_HEAD_WRITEBACK); + } + unlock_page(p); return ret; @@ -4208,24 +4287,31 @@ retry: j = 0; ebs_to_write = dirty_ebs = 0; + + lock_extent_buffers(ebh, &epd); + + set_bit(EXTENT_BUFFER_HEAD_WRITEBACK, &ebh->bflags); + eb = &ebh->eb; do { BUG_ON(j >= BITS_PER_LONG); - ret = lock_extent_buffer_for_io(eb, fs_info, &epd); + ret = mark_extent_buffer_writeback(eb, fs_info, + &epd); switch (ret) { case 0: /* - EXTENT_BUFFER_DIRTY was set and we were able to - clear it. + EXTENT_BUFFER_DIRTY was set and we were + able to clear it. */ set_bit(j, &ebs_to_write); break; case 2: /* - EXTENT_BUFFER_DIRTY was set, but we were unable - to clear EXTENT_BUFFER_WRITEBACK that was set - before we got the extent buffer locked. + EXTENT_BUFFER_DIRTY was set, but we were + unable to clear EXTENT_BUFFER_WRITEBACK + that was set before we got the extent + buffer locked. */ set_bit(j, &dirty_ebs); default: @@ -4239,22 +4325,32 @@ retry: ret = 0; + unlock_extent_buffers(ebh); + if (!ebs_to_write) { + clear_bit(EXTENT_BUFFER_HEAD_WRITEBACK, + &ebh->bflags); + smp_mb__after_atomic(); + wake_up_bit(&ebh->bflags, + EXTENT_BUFFER_HEAD_WRITEBACK); free_extent_buffer(&ebh->eb); continue; } /* - Now that we know that atleast one of the extent buffer + Now that we know that atleast one of the extent buffers belonging to the extent buffer head must be written to the disk, lock the extent_buffer_head's pages. */ lock_extent_buffer_pages(ebh, &epd); if (ebh->eb.len < PAGE_CACHE_SIZE) { - ret = write_subpagesize_blocksize_ebh(ebh, fs_info, wbc, &epd, ebs_to_write); + ret = write_subpagesize_blocksize_ebh(ebh, fs_info, + wbc, &epd, + ebs_to_write); if (dirty_ebs) { - redirty_extent_buffer_pages_for_writepage(&ebh->eb, wbc); + redirty_extent_buffer_pages_for_writepage(&ebh->eb, + wbc); } } else { ret = write_regular_ebh(ebh, fs_info, wbc, &epd); diff --git a/fs/btrfs/extent_io.h b/fs/btrfs/extent_io.h index 3802e19..9b777b0 100644 --- a/fs/btrfs/extent_io.h +++ b/fs/btrfs/extent_io.h @@ -36,6 +36,7 @@ #define EXTENT_BUFFER_HEAD_TREE_REF 0 #define EXTENT_BUFFER_HEAD_DUMMY 1 #define EXTENT_BUFFER_HEAD_IN_TREE 2 +#define EXTENT_BUFFER_HEAD_WRITEBACK 3 /* these are bit numbers for test/set bit on extent buffer */ #define EXTENT_BUFFER_UPTODATE 0