| Message ID | 1453725932-11053-1-git-send-email-ian.campbell@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
At 12:45 +0000 on 25 Jan (1453725932), Ian Campbell wrote: > This: > > kdd-xen.c: In function 'kdd_access_physical_page': > kdd-xen.c:508:9: warning: implicit declaration of function 'xc_map_foreign_range' [-Wimplicit-function-declaration] > map = xc_map_foreign_range(g->xc_handle, > ^ > kdd-xen.c:508:13: warning: assignment makes pointer from integer without a cast > map = xc_map_foreign_range(g->xc_handle, > ^ > > was caused by the refactoring of this functionality into > libxenforeignmemory. > > Reported by: Olaf Hering <olaf@aepfle.de> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> Acked-by: Tim Deegan <tim@xen.org>
On Mon, Jan 25, Ian Campbell wrote: > Reported by: Olaf Hering <olaf@aepfle.de> Tested-by: Olaf Hering <olaf@aepfle.de> Thanks, Olaf
On Mon, 2016-01-25 at 13:25 +0000, Tim Deegan wrote: > At 12:45 +0000 on 25 Jan (1453725932), Ian Campbell wrote: > > This: > > > > kdd-xen.c: In function 'kdd_access_physical_page': > > kdd-xen.c:508:9: warning: implicit declaration of function > > 'xc_map_foreign_range' [-Wimplicit-function-declaration] > > map = xc_map_foreign_range(g->xc_handle, > > ^ > > kdd-xen.c:508:13: warning: assignment makes pointer from integer > > without a cast > > map = xc_map_foreign_range(g->xc_handle, > > ^ > > > > was caused by the refactoring of this functionality into > > libxenforeignmemory. > > > > Reported by: Olaf Hering <olaf@aepfle.de> > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > > Acked-by: Tim Deegan <tim@xen.org> thanks, applied. (FTR, I skipped my usual full set of usual pre-push build tests, since the machines I use are unavailable right now. I have done an x86_64 make dist).
diff --git a/tools/debugger/kdd/Makefile b/tools/debugger/kdd/Makefile index a79d7cf..72ad1b9 100644 --- a/tools/debugger/kdd/Makefile +++ b/tools/debugger/kdd/Makefile @@ -2,6 +2,7 @@ XEN_ROOT = $(CURDIR)/../../.. include $(XEN_ROOT)/tools/Rules.mk CFLAGS += $(CFLAGS_libxenctrl) +CFLAGS += -DXC_WANT_COMPAT_MAP_FOREIGN_API LDLIBS += $(LDLIBS_libxenctrl) CFILES := kdd.c kdd-xen.c
This: kdd-xen.c: In function 'kdd_access_physical_page': kdd-xen.c:508:9: warning: implicit declaration of function 'xc_map_foreign_range' [-Wimplicit-function-declaration] map = xc_map_foreign_range(g->xc_handle, ^ kdd-xen.c:508:13: warning: assignment makes pointer from integer without a cast map = xc_map_foreign_range(g->xc_handle, ^ was caused by the refactoring of this functionality into libxenforeignmemory. Reported by: Olaf Hering <olaf@aepfle.de> Signed-off-by: Ian Campbell <ian.campbell@citrix.com> Cc: Tim Deegan <tim@xen.org> --- tools/debugger/kdd/Makefile | 1 + 1 file changed, 1 insertion(+)