| Message ID | 1306249521-23244-1-git-send-email-bharrosh@panasas.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 2011-05-24 18:05, Boaz Harrosh wrote: > The atomic_dec_and_test() returns *true* when zero. The ! > belongs to atomic_dec(). Fixit Thanks! Benny > > Signed-off-by: Boaz Harrosh <bharrosh@panasas.com> > --- > fs/nfs/pnfs_dev.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/nfs/pnfs_dev.c b/fs/nfs/pnfs_dev.c > index 7e5542c..37ca215 100644 > --- a/fs/nfs/pnfs_dev.c > +++ b/fs/nfs/pnfs_dev.c > @@ -258,7 +258,7 @@ _deviceid_purge_client(const struct nfs_client *clp, long hash) > > synchronize_rcu(); > hlist_for_each_entry_safe(d, n, next, &tmp, node) > - if (!atomic_dec_and_test(&d->ref)) { > + if (atomic_dec_and_test(&d->ref)) { > if (d->ld->free_deviceid_node) > d->ld->free_deviceid_node(d); > else -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/nfs/pnfs_dev.c b/fs/nfs/pnfs_dev.c index 7e5542c..37ca215 100644 --- a/fs/nfs/pnfs_dev.c +++ b/fs/nfs/pnfs_dev.c @@ -258,7 +258,7 @@ _deviceid_purge_client(const struct nfs_client *clp, long hash) synchronize_rcu(); hlist_for_each_entry_safe(d, n, next, &tmp, node) - if (!atomic_dec_and_test(&d->ref)) { + if (atomic_dec_and_test(&d->ref)) { if (d->ld->free_deviceid_node) d->ld->free_deviceid_node(d); else
The atomic_dec_and_test() returns *true* when zero. The ! belongs to atomic_dec(). Fixit Signed-off-by: Boaz Harrosh <bharrosh@panasas.com> --- fs/nfs/pnfs_dev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)