From patchwork Mon Feb 1 14:43:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emmanuel Grumbach X-Patchwork-Id: 8180151 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D1D23BEEE5 for ; Mon, 1 Feb 2016 14:43:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 09AFA20459 for ; Mon, 1 Feb 2016 14:43:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1167820434 for ; Mon, 1 Feb 2016 14:43:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933047AbcBAOnT (ORCPT ); Mon, 1 Feb 2016 09:43:19 -0500 Received: from mga01.intel.com ([192.55.52.88]:56751 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932645AbcBAOnR convert rfc822-to-8bit (ORCPT ); Mon, 1 Feb 2016 09:43:17 -0500 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 01 Feb 2016 06:43:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,380,1449561600"; d="scan'208";a="645183231" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 01 Feb 2016 06:43:17 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 1 Feb 2016 06:43:16 -0800 Received: from lcsmsx153.ger.corp.intel.com (10.186.165.228) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 1 Feb 2016 06:43:16 -0800 Received: from hasmsx107.ger.corp.intel.com ([169.254.6.145]) by LCSMSX153.ger.corp.intel.com ([169.254.8.99]) with mapi id 14.03.0248.002; Mon, 1 Feb 2016 16:43:09 +0200 From: "Grumbach, Emmanuel" To: Kalle Valo CC: "linux-wireless@vger.kernel.org" , "Coelho, Luciano" Subject: Re: [PATCH 04/31] iwlwifi: pcie: add initial RTPM support for PCI Thread-Topic: [PATCH 04/31] iwlwifi: pcie: add initial RTPM support for PCI Thread-Index: AQHRXP1gsrddvJyExE2fh0ozahNWWg== Date: Mon, 1 Feb 2016 14:43:09 +0000 Message-ID: <0BA3FCBA62E2DC44AF3030971E174FB32E9F687B@hasmsx107.ger.corp.intel.com> References: <0BA3FCBA62E2DC44AF3030971E174FB32E9F363A@hasmsx107.ger.corp.intel.com> <1454238386-27032-4-git-send-email-emmanuel.grumbach@intel.com> <87y4b4sdqo.fsf@purkki.adurom.net> <0BA3FCBA62E2DC44AF3030971E174FB32E9F682B@hasmsx107.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.12.125.84] MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 02/01/2016 04:38 PM, Grumbach, Emmanuel wrote: > > On 02/01/2016 04:32 PM, Kalle Valo wrote: >> Emmanuel Grumbach writes: >> >>> From: Luca Coelho >>> >>> Add an initial implementation of runtime power management (RTPM) for >>> PCI devices. With this patch, RTPM is only used when wifi is off >>> (i.e. the wifi interface is down). This implementation is behind a >>> new Kconfig flag, IWLWIFI_PCIE_RTPM. >>> >>> Signed-off-by: Luca Coelho >>> Signed-off-by: Emmanuel Grumbach >> [...] >> >>> --- a/drivers/net/wireless/intel/iwlwifi/Kconfig >>> +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig >>> @@ -99,6 +99,18 @@ config IWLWIFI_UAPSD >>> >>> If unsure, say N. >>> >>> +config IWLWIFI_PCIE_RTPM >>> + bool "Enable runtime power management mode for PCIe devices" >>> + depends on IWLMVM && IWLWIFI_PCIE && PM >>> + default false >>> + help >>> + Say Y here to enable runtime power management for PCIe >>> + devices. If enabled, the device will go into low power mode >>> + when idle for a short period of time, allowing for improved >>> + power saving during runtime. >>> + >>> + If unsure, say N. >> I didn't see the new option in menuconfig and then noticed that I can't >> find IWLWIFI_PCIE anywhere. Is that correct? >> > Right... This option is not upstreamed yet... > I'll respin. Sorry... > Next tag: iwlwifi-next-for-kalle-2016-01-31_2 $ git diff iwlwifi-next-for-kalle-2016-01-31..iwlwifi-next-for-kalle-2016-01-31_2 --- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig index acaaf69..11932d5 100644 --- a/drivers/net/wireless/intel/iwlwifi/Kconfig +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig @@ -101,7 +101,7 @@ config IWLWIFI_UAPSD config IWLWIFI_PCIE_RTPM bool "Enable runtime power management mode for PCIe devices" - depends on IWLMVM && IWLWIFI_PCIE && PM + depends on IWLMVM && PM default false help Say Y here to enable runtime power management for PCIe