diff mbox

[13/13] common: remove unneeded mount options for ext4

Message ID 1455170182-32587-14-git-send-email-tytso@mit.edu (mailing list archive)
State New, archived
Headers show

Commit Message

Theodore Ts'o Feb. 11, 2016, 5:56 a.m. UTC
Ext4 has turned on acls and xattrs by default for a long, long time
(even the 3.10 kernel has it on by default).

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
 common/config | 3 +++
 1 file changed, 3 insertions(+)

Comments

Dave Chinner Feb. 12, 2016, 3:57 a.m. UTC | #1
On Thu, Feb 11, 2016 at 12:56:22AM -0500, Theodore Ts'o wrote:
> Ext4 has turned on acls and xattrs by default for a long, long time
> (even the 3.10 kernel has it on by default).
> 
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>

Hmmm - aren't these really there for transparent support of older
distros that still require these mount options? e.g. RHEL6, older
SLES kernels, etc?

Cheers,

Dave.
Theodore Ts'o Feb. 12, 2016, 5:41 a.m. UTC | #2
On Fri, Feb 12, 2016 at 02:57:09PM +1100, Dave Chinner wrote:
> On Thu, Feb 11, 2016 at 12:56:22AM -0500, Theodore Ts'o wrote:
> > Ext4 has turned on acls and xattrs by default for a long, long time
> > (even the 3.10 kernel has it on by default).
> > 
> > Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> 
> Hmmm - aren't these really there for transparent support of older
> distros that still require these mount options? e.g. RHEL6, older
> SLES kernels, etc?

Good point.  I had forgotten (traumatic memory suppression, no doubt)
that there are poor souls who still have to support 2.6.32 kernels.
Only four more years before it goes EOL --- in 2020.  I'm so glad I
don't work in the enterprise space any more.  And I thought things
were bad with cell phones shipping with 3.10 kernels in 2016.  :-)

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/common/config b/common/config
index cacd815..e031a4a 100644
--- a/common/config
+++ b/common/config
@@ -300,6 +300,9 @@  _mount_opts()
 		# acls & xattrs aren't turned on by default on ext$FOO
 		export MOUNT_OPTIONS="-o acl,user_xattr $EXT_MOUNT_OPTIONS"
 		;;
+	ext4|ext4dev)
+		export MOUNT_OPTIONS="$EXT_MOUNT_OPTIONS"
+		;;
 	f2fs)
 		export MOUNT_OPTIONS="-o acl,user_xattr $F2FS_MOUNT_OPTIONS"
 		;;