em28xx-cards: fix compilation breakage caused by cs 622f9260802e
diff mbox

Message ID 87749d1653e4cf3af1c009e9b16c476957382325.1455196043.git.mchehab@osg.samsung.com
State New
Headers show

Commit Message

Mauro Carvalho Chehab Feb. 11, 2016, 1:07 p.m. UTC
changeset 622f9260802e ("tvp5150: move input definition header to
dt-bindings") broke compilation of em28xx, as it moved one header
file used there.

Fix it by pointing to the newer file location.

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
---
 drivers/media/usb/em28xx/em28xx-cards.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Javier Martinez Canillas Feb. 11, 2016, 1:29 p.m. UTC | #1
Hello Mauro,

On Thu, Feb 11, 2016 at 10:07 AM, Mauro Carvalho Chehab
<mchehab@osg.samsung.com> wrote:
> changeset 622f9260802e ("tvp5150: move input definition header to
> dt-bindings") broke compilation of em28xx, as it moved one header
> file used there.
>

Sigh, sorry for missing that the header was used in that driver too...

> Fix it by pointing to the newer file location.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

Thanks a lot for fixing this.

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
kbuild test robot Feb. 11, 2016, 1:49 p.m. UTC | #2
Hi Mauro,

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.5-rc3 next-20160211]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/em28xx-cards-fix-compilation-breakage-caused-by-cs-622f9260802e/20160211-211046
base:   git://linuxtv.org/media_tree.git master
config: i386-randconfig-a0-201606 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

>> drivers/media/usb/em28xx/em28xx-cards.c:35:39: fatal error: dt-bindings/media/tvp5150.h: No such file or directory
   compilation terminated.

vim +35 drivers/media/usb/em28xx/em28xx-cards.c

    29	#include <linux/delay.h>
    30	#include <linux/i2c.h>
    31	#include <linux/usb.h>
    32	#include <media/tuner.h>
    33	#include <media/drv-intf/msp3400.h>
    34	#include <media/i2c/saa7115.h>
  > 35	#include <dt-bindings/media/tvp5150.h>
    36	#include <media/i2c/tvaudio.h>
    37	#include <media/i2c-addr.h>
    38	#include <media/tveeprom.h>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Patch
diff mbox

diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/media/usb/em28xx/em28xx-cards.c
index ba442c967415..06a09b4e4a83 100644
--- a/drivers/media/usb/em28xx/em28xx-cards.c
+++ b/drivers/media/usb/em28xx/em28xx-cards.c
@@ -32,7 +32,7 @@ 
 #include <media/tuner.h>
 #include <media/drv-intf/msp3400.h>
 #include <media/i2c/saa7115.h>
-#include <media/i2c/tvp5150.h>
+#include <dt-bindings/media/tvp5150.h>
 #include <media/i2c/tvaudio.h>
 #include <media/i2c-addr.h>
 #include <media/tveeprom.h>