From patchwork Tue Feb 16 23:36:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Al Viro X-Patchwork-Id: 8333131 Return-Path: X-Original-To: patchwork-linux-fsdevel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 770379F372 for ; Tue, 16 Feb 2016 23:36:38 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AEFE5202F0 for ; Tue, 16 Feb 2016 23:36:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C6A57202AE for ; Tue, 16 Feb 2016 23:36:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933256AbcBPXgN (ORCPT ); Tue, 16 Feb 2016 18:36:13 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:59009 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933243AbcBPXgM (ORCPT ); Tue, 16 Feb 2016 18:36:12 -0500 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.76 #1 (Red Hat Linux)) id 1aVpA9-0002VF-8B; Tue, 16 Feb 2016 23:36:09 +0000 Date: Tue, 16 Feb 2016 23:36:09 +0000 From: Al Viro To: Mike Marshall Cc: Martin Brandenburg , Linus Torvalds , linux-fsdevel , Stephen Rothwell Subject: Re: Orangefs ABI documentation Message-ID: <20160216233609.GE17997@ZenIV.linux.org.uk> References: <20160213174738.GR17997@ZenIV.linux.org.uk> <20160214025615.GU17997@ZenIV.linux.org.uk> <20160214234312.GX17997@ZenIV.linux.org.uk> <20160215184554.GY17997@ZenIV.linux.org.uk> <20160215230434.GZ17997@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Feb 16, 2016 at 06:15:56PM -0500, Mike Marshall wrote: > Here's what I see: > > orangefs_create > service_operation > wait_for_matching_downcall purges op and returns -EAGAIN > orangefs_clean_up_interrupted_operation > if (EAGAIN) > ... > goto retry_servicing > wait_for_matching_downcall returns 0 > service_operation returns 0 > orangefs_create has good return value from service_operation > > op->khandle: 00000000-0000-0000-0000-000000000000 > op->fs_id: 0 > > subsequent getattr on bogus object fails orangefs_create on EINVAL. > > seems like the second time around, wait_for_matching_downcall > must have seen op_state_serviced, but I don't see how yet... I strongly suspect that this is what's missing. Could you check if it helps? --- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/orangefs/waitqueue.c b/fs/orangefs/waitqueue.c index 2539813..36eedd6 100644 --- a/fs/orangefs/waitqueue.c +++ b/fs/orangefs/waitqueue.c @@ -244,6 +244,7 @@ static void orangefs_clean_up_interrupted_operation(struct orangefs_kernel_op_s gossip_err("%s: can't get here.\n", __func__); spin_unlock(&op->lock); } + reinit_completion(&op->waitq); } /*