From patchwork Wed Feb 17 10:02:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: chenjie6@huawei.com X-Patchwork-Id: 8333681 Return-Path: X-Original-To: patchwork-linux-fsdevel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 569349F6E7 for ; Wed, 17 Feb 2016 02:00:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 91CC52026C for ; Wed, 17 Feb 2016 02:00:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A5EDB2020F for ; Wed, 17 Feb 2016 02:00:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933538AbcBQCAK (ORCPT ); Tue, 16 Feb 2016 21:00:10 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:9242 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933358AbcBQCAK (ORCPT ); Tue, 16 Feb 2016 21:00:10 -0500 Received: from 172.24.1.51 (EHLO SZXEML429-HUB.china.huawei.com) ([172.24.1.51]) by szxrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id DBM65373; Wed, 17 Feb 2016 10:00:03 +0800 (CST) Received: from linux-git.site (10.67.54.28) by SZXEML429-HUB.china.huawei.com (10.82.67.184) with Microsoft SMTP Server id 14.3.235.1; Wed, 17 Feb 2016 09:59:53 +0800 From: To: Alexander Viro , Matthew Wilcox , , CC: , , chenjie , Subject: [PATCH] bugfix of access a invalid addr Date: Wed, 17 Feb 2016 18:02:45 +0800 Message-ID: <1455703365-21406-1-git-send-email-chenjie6@huawei.com> X-Mailer: git-send-email 1.8.0 MIME-Version: 1.0 X-Originating-IP: [10.67.54.28] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.56C3D424.00FC, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: d3504cb0cd857532d5ffe9369758d672 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DATE_IN_FUTURE_06_12, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: chenjie when we run fs_fsbase_t, some testcase like write05 failed write05 0 TINFO : Enter Block 1: test with bad fd write05 1 TPASS : received EBADF as expected. write05 0 TINFO : Exit Block 1 write05 0 TINFO : Enter Block 2: test with a bad address write05 2 TFAIL : write() on an invalid buffer succeeded, but should have failed Cc: Signed-off-by: chenjie --- fs/dax.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/fs/dax.c b/fs/dax.c index fc2e314..e1b1ff6 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -214,6 +214,11 @@ static ssize_t dax_io(struct inode *inode, struct iov_iter *iter, max = min(pos + size, end); } + if (unlikely(iov_iter_fault_in_readable(iter, max - pos))) { + retval = -EFAULT; + break; + } + if (iov_iter_rw(iter) == WRITE) { len = copy_from_iter_pmem(dax.addr, max - pos, iter); need_wmb = true;