| Message ID | 1455707783-31789-1-git-send-email-javier@javigon.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 02/17/2016 12:16 PM, Javier González wrote: > When the l2p table is loaded, addresses are checked for the lun they > belong to and luns are reserved accordingly. This assumes that metadata > is being stored in the backend device to recover the previous target > configuration. Since this is not yet implemented, this check collides > with some of the core initialization (e.g., sysblock initialization when > a page is formed by several sectors). > > We take this check out and for now rely on that the right target will be > created instead. When metadata is stored to recover a target, this check > will come natural as aprt of the recovery strategy. > > FIXES c87ea75 > > Signed-off-by: Javier González <javier@cnexlabs.com> > --- > drivers/lightnvm/gennvm.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/lightnvm/gennvm.c b/drivers/lightnvm/gennvm.c > index b97801c..42c1c2a 100644 > --- a/drivers/lightnvm/gennvm.c > +++ b/drivers/lightnvm/gennvm.c > @@ -192,9 +192,6 @@ static int gennvm_block_map(u64 slba, u32 nlb, __le64 *entries, void *private) > lun_id = div_u64(pba, dev->sec_per_lun); > lun = &gn->luns[lun_id]; > > - if (!test_bit(lun_id, dev->lun_map)) > - __set_bit(lun_id, dev->lun_map); > - > /* Calculate block offset into lun */ > pba = pba - (dev->sec_per_lun * lun_id); > blk = &lun->vlun.blocks[div_u64(pba, dev->sec_per_blk)]; > Thanks Javier, applied. -Matias -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/lightnvm/gennvm.c b/drivers/lightnvm/gennvm.c index b97801c..42c1c2a 100644 --- a/drivers/lightnvm/gennvm.c +++ b/drivers/lightnvm/gennvm.c @@ -192,9 +192,6 @@ static int gennvm_block_map(u64 slba, u32 nlb, __le64 *entries, void *private) lun_id = div_u64(pba, dev->sec_per_lun); lun = &gn->luns[lun_id]; - if (!test_bit(lun_id, dev->lun_map)) - __set_bit(lun_id, dev->lun_map); - /* Calculate block offset into lun */ pba = pba - (dev->sec_per_lun * lun_id); blk = &lun->vlun.blocks[div_u64(pba, dev->sec_per_blk)];
When the l2p table is loaded, addresses are checked for the lun they belong to and luns are reserved accordingly. This assumes that metadata is being stored in the backend device to recover the previous target configuration. Since this is not yet implemented, this check collides with some of the core initialization (e.g., sysblock initialization when a page is formed by several sectors). We take this check out and for now rely on that the right target will be created instead. When metadata is stored to recover a target, this check will come natural as aprt of the recovery strategy. FIXES c87ea75 Signed-off-by: Javier González <javier@cnexlabs.com> --- drivers/lightnvm/gennvm.c | 3 --- 1 file changed, 3 deletions(-)