| Message ID | 1455723595-30904-1-git-send-email-ian.campbell@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Ian Campbell writes ("[PATCH] xenpaging: don't try to log via xch if xc_interface_close fails"):
> Since xch may not be valid (enough) any longer, xc_interface_close
> already logs anything of any use before it tears down the integrated
> logger so there is no need to log any further in the application via
> that path.
>
> CID: 1056203
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
and queued.
Ian.
diff --git a/tools/xenpaging/xenpaging.c b/tools/xenpaging/xenpaging.c index 6157d3a..d0571ca 100644 --- a/tools/xenpaging/xenpaging.c +++ b/tools/xenpaging/xenpaging.c @@ -550,11 +550,7 @@ static void xenpaging_teardown(struct xenpaging *paging) xs_close(paging->xs_handle); /* Close connection to Xen */ - rc = xc_interface_close(xch); - if ( rc != 0 ) - { - ERROR("Error closing connection to xen"); - } + xc_interface_close(xch); } static void get_request(struct vm_event *vm_event, vm_event_request_t *req)
Since xch may not be valid (enough) any longer, xc_interface_close already logs anything of any use before it tears down the integrated logger so there is no need to log any further in the application via that path. CID: 1056203 Signed-off-by: Ian Campbell <ian.campbell@citrix.com> --- tools/xenpaging/xenpaging.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)