From patchwork Sat Feb 20 16:45:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Dryomov X-Patchwork-Id: 8367051 Return-Path: X-Original-To: patchwork-ceph-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 945C59F314 for ; Sat, 20 Feb 2016 16:46:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CABC420465 for ; Sat, 20 Feb 2016 16:46:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EFAC62010F for ; Sat, 20 Feb 2016 16:46:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757881AbcBTQqj (ORCPT ); Sat, 20 Feb 2016 11:46:39 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:35609 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757849AbcBTQp5 (ORCPT ); Sat, 20 Feb 2016 11:45:57 -0500 Received: by mail-wm0-f41.google.com with SMTP id c200so116208809wme.0 for ; Sat, 20 Feb 2016 08:45:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4Z2yMsdRIlzkaekk5mbz90GeFB1TQA9CPHuk4XnjAvI=; b=M8vFPKX93aIbwikPmbuLpEKUdrQNmHwzsb/mASknRukbcgvNEUu/DY1omtMRVZ5qpS MR/rVIH+QMbB05CJAmvc+Wv7K3tKcXNztBeFpdyM4jgkydcJXKojTowi1DWGQQGZvM94 33tRizVVEhhUyhdfLbAnJNAHIf1W16umRInmtjO8zNuROhNKNasa8t6F472+ZGmnO15A K+SKgyeIye/h8hJjPVqtOKsKr9smLowlBUBGKL7rimdM+Pq3okyZClmJtClN2r0ua8/1 liiuk66tunSQ+gPnrdCquqmhJX7XRuqvRsij0GbCFSlmDZCPg85Smlah6eh4kd/Cw/ye 7V6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4Z2yMsdRIlzkaekk5mbz90GeFB1TQA9CPHuk4XnjAvI=; b=gdwivKCIwbrhLlcLN+LsUiWO6GVHgSosLsKtzKXuU5jyJ/PVvC+FSWCO1HkzUl+KhM lZeKiwEop09m+gGVDUKYNuzF4NLvSEC0U4k2I/qQP0ARh/CYNtgx8X16m8Qtbs0dUwQt QnJEBo/2XNTerRauQ+SmNgN9AvMcHgWaSQLA9n6KLkRslbUNSRR4GgJEW+9sw/kQjnCi L7bsNWpsU3lqxyWMO6kFugxZ8rhW2z4VRFYDZCTa0WjHpEeWRtmbmxrDqojAw87IuUwN cNdI04RRd4rqXw2GEVj7ks7Us3mF3CJ2Sv+K3n5E4wnoYpUbB5H6LWJN6WLmqvaHzzZq Gqhg== X-Gm-Message-State: AG10YOT0WroldbUDq+08XjbyFWd45CgWqrRxm56CaV0+svcIjwhjgmbvg9Ev7d/cKtRP6g== X-Received: by 10.194.250.35 with SMTP id yz3mr21251553wjc.173.1455986756507; Sat, 20 Feb 2016 08:45:56 -0800 (PST) Received: from dhcp-26-205.brq.redhat.com (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id e19sm12784798wmd.1.2016.02.20.08.45.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 Feb 2016 08:45:55 -0800 (PST) From: Ilya Dryomov To: ceph-devel@vger.kernel.org Cc: Varada Kari Subject: [PATCH 3/4] libceph: don't spam dmesg with stray reply warnings Date: Sat, 20 Feb 2016 17:45:28 +0100 Message-Id: <1455986729-12544-4-git-send-email-idryomov@gmail.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1455986729-12544-1-git-send-email-idryomov@gmail.com> References: <1455986729-12544-1-git-send-email-idryomov@gmail.com> Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit d15f9d694b77 ("libceph: check data_len in ->alloc_msg()") mistakenly bumped the log level on the "tid %llu unknown, skipping" message. Turn it back into a dout() - stray replies are perfectly normal when OSDs flap, crash, get killed for testing purposes, etc. Cc: stable@vger.kernel.org # 4.3+ Signed-off-by: Ilya Dryomov Reviewed-by: Alex Elder --- net/ceph/osd_client.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c index 7c1a5d1734c3..32355d9d0103 100644 --- a/net/ceph/osd_client.c +++ b/net/ceph/osd_client.c @@ -2890,8 +2890,8 @@ static struct ceph_msg *get_reply(struct ceph_connection *con, mutex_lock(&osdc->request_mutex); req = __lookup_request(osdc, tid); if (!req) { - pr_warn("%s osd%d tid %llu unknown, skipping\n", - __func__, osd->o_osd, tid); + dout("%s osd%d tid %llu unknown, skipping\n", __func__, + osd->o_osd, tid); m = NULL; *skip = 1; goto out;