| Message ID | 20160222030304.GV11419@eguan.usersys.redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Feb 22, 2016 at 11:03:04AM +0800, Eryu Guan wrote: > Hi, > > After upgrading to xfsprogs v4.5-rc1 version, xfstests failed to built > because of configure error: > > checking xfs/xfs.h usability... no > checking xfs/xfs.h presence... yes > configure: WARNING: xfs/xfs.h: present but cannot be compiled > configure: WARNING: xfs/xfs.h: check for missing prerequisite headers? > configure: WARNING: xfs/xfs.h: see the Autoconf documentation > configure: WARNING: xfs/xfs.h: section "Present But Cannot Be Compiled" > configure: WARNING: xfs/xfs.h: proceeding with the compiler's result > checking for xfs/xfs.h... no > > FATAL ERROR: cannot find a valid <xfs/xfs.h> header file. > Run "make install-qa" from the xfsprogs source. > > and config.log showed: > > configure:4543: checking xfs/xfs.h usability > configure:4543: ccache gcc -c -g -O2 conftest.c >&5 > In file included from /usr/include/xfs/xfs.h:37:0, > from conftest.c:73: > /usr/include/xfs/linux.h:145:1: error: unknown type name 'off64_t' > typedef off64_t xfs_off_t; > ^ > configure:4543: $? = 1 That would seem like a system library problem in that it doesn't define off64_t through stdio.h. What distro are you compiling on? Also, if you set _GNU_SOURCE, does it then compile? e.g. see m4/package_libcdev.m4 for how to test whether code compiles under certain defines. If it does compile with _GNU_SOURCE being set, then all that needs to be is to update the autoconf rule. Cheers, Dave.
On Mon, Feb 22, 2016 at 02:24:50PM +1100, Dave Chinner wrote: > On Mon, Feb 22, 2016 at 11:03:04AM +0800, Eryu Guan wrote: > > Hi, > > > > After upgrading to xfsprogs v4.5-rc1 version, xfstests failed to built > > because of configure error: > > > > checking xfs/xfs.h usability... no > > checking xfs/xfs.h presence... yes > > configure: WARNING: xfs/xfs.h: present but cannot be compiled > > configure: WARNING: xfs/xfs.h: check for missing prerequisite headers? > > configure: WARNING: xfs/xfs.h: see the Autoconf documentation > > configure: WARNING: xfs/xfs.h: section "Present But Cannot Be Compiled" > > configure: WARNING: xfs/xfs.h: proceeding with the compiler's result > > checking for xfs/xfs.h... no > > > > FATAL ERROR: cannot find a valid <xfs/xfs.h> header file. > > Run "make install-qa" from the xfsprogs source. > > > > and config.log showed: > > > > configure:4543: checking xfs/xfs.h usability > > configure:4543: ccache gcc -c -g -O2 conftest.c >&5 > > In file included from /usr/include/xfs/xfs.h:37:0, > > from conftest.c:73: > > /usr/include/xfs/linux.h:145:1: error: unknown type name 'off64_t' > > typedef off64_t xfs_off_t; > > ^ > > configure:4543: $? = 1 > > That would seem like a system library problem in that it doesn't > define off64_t through stdio.h. What distro are you compiling on? It's a RHEL7.2 box. > Also, if you set _GNU_SOURCE, does it then compile? e.g. see > m4/package_libcdev.m4 for how to test whether code compiles under > certain defines. Okay, I'll go through the m4 files and test around. Thanks, Eryu > > If it does compile with _GNU_SOURCE being set, then all that needs > to be is to update the autoconf rule. > > Cheers, > > Dave. > -- > Dave Chinner > david@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux.h b/include/linux.h index cc0f70c..d66436c 100644 --- a/include/linux.h +++ b/include/linux.h @@ -142,7 +142,7 @@ platform_discard_blocks(int fd, uint64_t start, uint64_t len) #define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */ #define EFSBADCRC EBADMSG /* Bad CRC detected */ -typedef off64_t xfs_off_t; +typedef __off64_t xfs_off_t; typedef __uint64_t xfs_ino_t; typedef __uint32_t xfs_dev_t; typedef __int64_t xfs_daddr_t;
Hi, After upgrading to xfsprogs v4.5-rc1 version, xfstests failed to built because of configure error: checking xfs/xfs.h usability... no checking xfs/xfs.h presence... yes configure: WARNING: xfs/xfs.h: present but cannot be compiled configure: WARNING: xfs/xfs.h: check for missing prerequisite headers? configure: WARNING: xfs/xfs.h: see the Autoconf documentation configure: WARNING: xfs/xfs.h: section "Present But Cannot Be Compiled" configure: WARNING: xfs/xfs.h: proceeding with the compiler's result checking for xfs/xfs.h... no FATAL ERROR: cannot find a valid <xfs/xfs.h> header file. Run "make install-qa" from the xfsprogs source. and config.log showed: configure:4543: checking xfs/xfs.h usability configure:4543: ccache gcc -c -g -O2 conftest.c >&5 In file included from /usr/include/xfs/xfs.h:37:0, from conftest.c:73: /usr/include/xfs/linux.h:145:1: error: unknown type name 'off64_t' typedef off64_t xfs_off_t; ^ configure:4543: $? = 1 It's the change made by commit cb898f157f84 ("linux.h: Use off64_t instead of loff_t") introduced this error. If I do the following modifications xfstests compiles without errors: But I'm not sure if it's a proper fix. Thanks, Eryu -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html