[RESEND] ASoC: pxa: remove unused variable
diff mbox

Message ID 1456437736-732609-1-git-send-email-arnd@arndb.de
State New
Headers show

Commit Message

Arnd Bergmann Feb. 25, 2016, 10:02 p.m. UTC
As pointed out by Zhangfei Gao, the sspa_div variable in
brownstone_wm8994_hw_params() is completely unused, so as a cleanup
following a prior patch, this removes both the variable and the division.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Submitted originally on Nov 23 2015, this apparently got lost,
resending it now.

 sound/soc/pxa/brownstone.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Mark Brown Feb. 26, 2016, 1:18 a.m. UTC | #1
On Thu, Feb 25, 2016 at 11:02:04PM +0100, Arnd Bergmann wrote:

> Submitted originally on Nov 23 2015, this apparently got lost,
> resending it now.

You didn't really submit it, you pasted it into the middle of a reply to
a message on an existing thread for a patch that was already applied:

https://lkml.org/lkml/2015/11/23/88

That's not really submitting a patch as far as I'm concerned, something
that won't just apply with git am without special faffing isn't helping
and things in the middle of threads aren't good either (it gets
difficult to follow and there's every chance they'll never even get seen
if they're buried in the middle of a reply where you don't expect to see
a patch).
Arnd Bergmann Feb. 26, 2016, 1:46 p.m. UTC | #2
On Friday 26 February 2016 10:18:27 Mark Brown wrote:
> On Thu, Feb 25, 2016 at 11:02:04PM +0100, Arnd Bergmann wrote:
> 
> > Submitted originally on Nov 23 2015, this apparently got lost,
> > resending it now.
> 
> You didn't really submit it, you pasted it into the middle of a reply to
> a message on an existing thread for a patch that was already applied:
> 
> https://lkml.org/lkml/2015/11/23/88
> 
> That's not really submitting a patch as far as I'm concerned, something
> that won't just apply with git am without special faffing isn't helping
> and things in the middle of threads aren't good either (it gets
> difficult to follow and there's every chance they'll never even get seen
> if they're buried in the middle of a reply where you don't expect to see
> a patch).

I see your point about the patch being in the middle of the thread.

Regarding the 'git am' compatibility, I thought I'd done it right,
but see now that I used incorrect scissors, apparently 'git mailinfo'
expects at least six '-' characters as the separator, while I used
just three.

	Arnd

Patch
diff mbox

diff --git a/sound/soc/pxa/brownstone.c b/sound/soc/pxa/brownstone.c
index 416ea646c3b1..ec522e94b0e2 100644
--- a/sound/soc/pxa/brownstone.c
+++ b/sound/soc/pxa/brownstone.c
@@ -52,7 +52,6 @@  static int brownstone_wm8994_hw_params(struct snd_pcm_substream *substream,
 	struct snd_soc_dai *codec_dai = rtd->codec_dai;
 	struct snd_soc_dai *cpu_dai = rtd->cpu_dai;
 	int freq_out, sspa_mclk, sysclk;
-	int sspa_div;
 
 	if (params_rate(params) > 11025) {
 		freq_out  = params_rate(params) * 512;
@@ -63,7 +62,6 @@  static int brownstone_wm8994_hw_params(struct snd_pcm_substream *substream,
 		sysclk    = params_rate(params) * 512;
 		sspa_mclk = params_rate(params) * 64;
 	}
-	sspa_div = freq_out / sspa_mclk;
 
 	snd_soc_dai_set_sysclk(cpu_dai, MMP_SSPA_CLK_AUDIO, freq_out, 0);
 	snd_soc_dai_set_pll(cpu_dai, MMP_SYSCLK, 0, freq_out, sysclk);