From patchwork Fri Feb 26 12:22:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 8436411 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 3F5EA9F1D4 for ; Fri, 26 Feb 2016 12:23:23 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5B48B2039E for ; Fri, 26 Feb 2016 12:23:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 52A2220303 for ; Fri, 26 Feb 2016 12:23:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752671AbcBZMXU (ORCPT ); Fri, 26 Feb 2016 07:23:20 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:57386 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751124AbcBZMXT (ORCPT ); Fri, 26 Feb 2016 07:23:19 -0500 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue005) with ESMTPA (Nemesis) id 0Mb5Ch-1aKdup2Sj5-00Kifk; Fri, 26 Feb 2016 13:22:44 +0100 From: Arnd Bergmann To: Viresh Kumar , "Rafael J. Wysocki" Cc: linux-arm-kernel@lists.infradead.org, Jia Hongtao , "Rafael J . Wysocki" , Arnd Bergmann , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] cpufreq: qoriq depends on thermal Date: Fri, 26 Feb 2016 13:22:35 +0100 Message-Id: <1456489361-469413-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:ntWmIaw9pPyfLSkP0YKXDNC3fRy/C4jOQ9D9PDJeSdeL/rvLw/P D0wREr7Hxghs5YDUSwj8QE0wbBKskCLD46QgvtvHnRjTMOM7z/5pr1KgFRCME6rRabcZld9 0mphdEcjFvj1CT9cr/wSokD/n0TrRByEHzX6ZnlLXytFOYpWjfEHuKwiHcGqRSl4eyVl0UH WQFlbyCo9HrtUvNF5U9RQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:9ui5kAsLMUo=:hquwjvnN31AGh1eviIgNEP ie9hvL1yUX9u5yl9wOvVoQ+RPnwiyH9C8y1Aj9vn2mqqWguedyfO4DqxU6fZknL9KTlckG74A XAGLro+Q3EA8IZXETQmKvUiEfPgK6ZfHPwW3BdZ4wNSd+KGedyVXbdf4tK4lofvhh2sLgyqNp we77j5imss80vTHeOogts750gKWUZnPXZ/xxozcMyTNuDx8+wpzWY3Z1spXgP+H92ZI9QrPZb NN5ySFjf1fThjpGT8GLJ7DbK6mRftD8Spm6LVPu+Ai+obgFDH1z1NWkV2az7q2Vk2KPj5+Gsn Z+4IyyXz3k+fW8krqZk34F8HbDQFMalSZz8jQeIKDDWaThh2Ni4mH1/jYAVU8iYCXpwnHfqA0 f8oznJUzqPkGQOAkhqIb+Yq5OicGe7nSZEIgy1/fZDoQtFLF56Ey5YktW3Ctbf0M+FxC0f6PG OoDkHfiQDXT5FpbT3kUe6hCJiqYrxpw7WZ06YAYwI8b9HUaeHVZ1egqTiXkJkivDkfgSM4VKV pvq6oFYP3NOyw7EWtTMPEqHsNk+qzo2uB0nE326mgsyUXAWryTv5hEGWpjWVAFn0hkyT0sRWA O8X9K2jMwKUitWOodWrAC83W0cF3unEAmQYG4p3onT6AKX1YFrBSVZz/lGCWFdf4TA27glLuW tRF2bi9qtvjnhBVrcgHWmY4+Va/EN/CutftuiJVjn/fWzib5+Shol0l1YREzQZVeFabg= Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The thermal subsystem can be a loadable module, so the qoriq driver has to be a module in that case as well in order to call of_cpufreq_cooling_register: drivers/built-in.o: In function `qoriq_cpufreq_ready': text+0x1f4548): undefined reference to `of_cpufreq_cooling_register' This adds a dependency that clarifies how we can either build the driver when the cpu_thermal support is completely disabled, or how it depends on the thermal support to enforce the qoriq driver to be a module. Signed-off-by: Arnd Bergmann Fixes: 8ae1702a0df5 ("cpufreq: qoriq: Register cooling device based on device tree") Acked-by: Viresh Kumar --- drivers/cpufreq/Kconfig | 1 + 1 file changed, 1 insertion(+) My patch is from Dec 22, and I had marked it as submitted, but can't find the email now, so maybe I forgot to send it out back then. The problem still exists in linux-next, please apply the patch for 4.6. diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig index dcb972a38fbc..ca05037dd565 100644 --- a/drivers/cpufreq/Kconfig +++ b/drivers/cpufreq/Kconfig @@ -297,6 +297,7 @@ endif config QORIQ_CPUFREQ tristate "CPU frequency scaling driver for Freescale QorIQ SoCs" depends on OF && COMMON_CLK && (PPC_E500MC || ARM) + depends on !CPU_THERMAL || THERMAL=y select CLK_QORIQ help This adds the CPUFreq driver support for Freescale QorIQ SoCs