pblk: fix call_kern.cocci warnings
diff mbox

Message ID alpine.DEB.2.02.1602262153260.2055@localhost6.localdomain6
State New
Headers show

Commit Message

Julia Lawall Feb. 26, 2016, 8:57 p.m. UTC
Convert GFP_KERNEL to GFP_ATOMIC in a function that may be called with 
locks held.

See the call site on line 751, and the call to spin_lock on line 744.

Generated by: scripts/coccinelle/locks/call_kern.cocci

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>

Perhaps there is a way to reorganize the code such that pblk_get_blk is 
not called under the lock.

tree:   https://github.com/OpenChannelSSD/linux.git pblk
head:   01eab75e8310ada5c5d387ee0d77c9051f2ba238
commit: 8e755964c7e8b0266a95fb90557823dacf9da12f [11/21] pblk: do not use 
mempool for write buffer allocation

 pblk.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

diff mbox

--- a/drivers/lightnvm/pblk.c
+++ b/drivers/lightnvm/pblk.c
@@ -282,14 +282,14 @@  static struct pblk_block *pblk_get_blk(s
 	void *data;
 	int nentries = dev->sec_per_blk;
-	data = kmalloc(dev->sec_per_blk * dev->sec_size, GFP_KERNEL);
+	data = kmalloc(dev->sec_per_blk * dev->sec_size, GFP_ATOMIC);
 	if (!data) {
 		pr_err("nvm: pblk: cannot allocate write buffer for block\n");
 		return NULL;
 	entries = kmalloc(dev->sec_per_blk * sizeof(struct buf_entry),
-								GFP_KERNEL);
+								GFP_ATOMIC);
 	if (!entries) {
 		pr_err("nvm: pblk: cannot allocate write buffer for block\n");
@@ -297,7 +297,7 @@  static struct pblk_block *pblk_get_blk(s
 	sync_bitmap = kmalloc(BITS_TO_LONGS(nentries) * sizeof(unsigned long),
-								GFP_KERNEL);
+								GFP_ATOMIC);
 	if (!sync_bitmap) {