| Message ID | 1456824983-13550-1-git-send-email-a.hajda@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Mar 01, 2016 at 10:36:23AM +0100, Andrzej Hajda wrote: > The function can return negative value so it should be assigned to signed > variable. The patch changes also type of related i variable to make code > more compact and coherent. > > The problem has been detected using patch > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > --- > drivers/iommu/mtk_iommu.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied, thanks.
On Tue, 2016-03-01 at 12:34 +0100, Joerg Roedel wrote: > On Tue, Mar 01, 2016 at 10:36:23AM +0100, Andrzej Hajda wrote: > > The function can return negative value so it should be assigned to signed > > variable. The patch changes also type of related i variable to make code > > more compact and coherent. > > > > The problem has been detected using patch > > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci. > > > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > > --- > > drivers/iommu/mtk_iommu.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > Applied, thanks. Thanks. nit: It would be better to use iommu/mediatek. > > _______________________________________________ > iommu mailing list > iommu@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu
diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index 721ffdb..de9241b 100644 --- a/drivers/iommu/mtk_iommu.c +++ b/drivers/iommu/mtk_iommu.c @@ -578,8 +578,7 @@ static int mtk_iommu_probe(struct platform_device *pdev) struct resource *res; struct component_match *match = NULL; void *protect; - unsigned int i, larb_nr; - int ret; + int i, larb_nr, ret; data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); if (!data)
The function can return negative value so it should be assigned to signed variable. The patch changes also type of related i variable to make code more compact and coherent. The problem has been detected using patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci. Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> --- drivers/iommu/mtk_iommu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)