[rft/rfc/patch-v2.6.29-rc5+,23/23] usb: host: ehci: add few comments and todo
diff mbox

Message ID 1235415335-17408-24-git-send-email-me@felipebalbi.com
State RFC
Delegated to: Felipe Balbi
Headers show

Commit Message

Felipe Balbi Feb. 23, 2009, 6:55 p.m. UTC
Still a few stuff to be done with this driver, so add TODO
for us to keep track of what has to be done still.

Signed-off-by: Felipe Balbi <me@felipebalbi.com>
---
 drivers/usb/host/ehci-omap.c |   17 +++++++++++++++++
 1 files changed, 17 insertions(+), 0 deletions(-)

Patch
diff mbox

diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
index ebfed95..ad2a353 100644
--- a/drivers/usb/host/ehci-omap.c
+++ b/drivers/usb/host/ehci-omap.c
@@ -26,6 +26,14 @@ 
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA
  *
+ * TODO (last updated Feb 23rd, 2009):
+ *	- add kernel-doc
+ *	- enable AUTOIDLE
+ *	- move DPLL5 programming to clock fw
+ *	- add suspend/resume
+ *	- move workarounds to board-files
+ *	- differentiate between ES2.x and ES3.x
+ *	- make it enumerate devices
  */
 
 #include <linux/platform_device.h>
@@ -145,6 +153,15 @@  struct ehci_hcd_omap {
 	struct clk		*usbtll_fck;
 	struct clk		*usbtll_ick;
 
+	/* FIXME the following two workarounds are
+	 * board specific not silicon-specific so these
+	 * should be moved to board-file instead.
+	 *
+	 * Maybe someone from TI will know better which
+	 * board is affected and needs the workarounds
+	 * to be applied
+	 */
+
 	/* gpio for resetting phy */
 	int			reset_gpio_port1;
 	int			reset_gpio_port2;