From patchwork Thu Mar 3 05:30:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 8488061 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B04C49FC9D for ; Thu, 3 Mar 2016 05:31:46 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 168D820145 for ; Thu, 3 Mar 2016 05:31:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B7E820254 for ; Thu, 3 Mar 2016 05:31:45 +0000 (UTC) Received: from localhost ([::1]:60632 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abLrU-0007Pr-Jn for patchwork-qemu-devel@patchwork.kernel.org; Thu, 03 Mar 2016 00:31:44 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abLrG-0007Ou-UM for qemu-devel@nongnu.org; Thu, 03 Mar 2016 00:31:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abLrD-00031g-Fu for qemu-devel@nongnu.org; Thu, 03 Mar 2016 00:31:30 -0500 Received: from mail-qg0-x241.google.com ([2607:f8b0:400d:c04::241]:33080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abLrD-00031Y-Bb for qemu-devel@nongnu.org; Thu, 03 Mar 2016 00:31:27 -0500 Received: by mail-qg0-x241.google.com with SMTP id y89so760941qge.0 for ; Wed, 02 Mar 2016 21:31:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=GGqxhIZUXC8ItzXvex/YvE0tOXQ9/a5zLercoXY3lew=; b=mAxA2VaRrcTSsYSVQCACR4rOOlSdyIE1e+wUcHCYSaQds5kXB+UmpQiJPRIc0EGcYZ BhWGxv1a8cUqGFl48vKXHdLhwS3S3EweJp+PqfOVw/NHW2NTSV6h6DpvcuubwIQMXM8Z vGMBdaEHEVgyI1sBtllJW+FxKUMOrCNaFkg6nKdmMCm3tB/dp2qKpXJCn/Ah+O7UPPQz p++DjVW+V8zk/Gg0ipCvpWmwhQa+wiG2Kxoq0gX1RlVUyhWWaEj3lTCJRsRiWhfuGSh1 Wf0yZF4dvnWMxY7qY1Gdcr7Hf8B1hPBqr1X9tzV9Vn5l7sK8Z+3MeUEh23WrOLM2z/Ez aV1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=GGqxhIZUXC8ItzXvex/YvE0tOXQ9/a5zLercoXY3lew=; b=KcP8yB2wZ/R/nu/BUKdBiPzB7sw06FUBLgTC/hRmg/s3V1vIJXxLWhBEcUo9t1YJWT YLSfL5/pHld5RUAqPrwbWnmHQoukNcCqEV1BCf8xtfEZstLzGx5VwgJivF39Uma/yBGx 3rIVHzZ1RxZGV9RvHpeL1dYT2acU6WmCgZ8yyVxwaT+L9Vb2NTXxkf6EGpBOSxa0SGOO za9PbjMnrEQiSRIFnRSMFjt1uIWoKqgCuJB6CoYQ3OyO2eYrQLe0XEql5CaO1xcha6RA HByrsY+c3iw4iJbTr5P3f3FpzxbFqBF4qyjZeAvTxDpb/t8TgHDsJyoULhGLqjxLjSb4 6sxQ== X-Gm-Message-State: AD7BkJLK+iwayfIfGQPG9KBv7D9MTLAmV3A/E1Dk1F0lmvQ9glSM8qf8ddDi6PfjjLRbGw== X-Received: by 10.140.129.79 with SMTP id 76mr859583qhb.28.1456983086987; Wed, 02 Mar 2016 21:31:26 -0800 (PST) Received: from bigtime.com (50-194-63-110-static.hfc.comcastbusiness.net. [50.194.63.110]) by smtp.gmail.com with ESMTPSA id v65sm2301368qhv.6.2016.03.02.21.31.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Mar 2016 21:31:26 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 2 Mar 2016 21:30:45 -0800 Message-Id: <1456983051-14707-2-git-send-email-rth@twiddle.net> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1456983051-14707-1-git-send-email-rth@twiddle.net> References: <1456983051-14707-1-git-send-email-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c04::241 Cc: pbonzini@redhat.com, hpoussin@reactos.org Subject: [Qemu-devel] [PATCH 1/7] target-i386: avoid repeated calls to the bnd_jmp helper X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Paolo Bonzini Two flags were tested the wrong way. Signed-off-by: Paolo Bonzini Message-Id: <1456845145-18891-1-git-send-email-pbonzini@redhat.com> Signed-off-by: Richard Henderson [rth: Fixed enable test as well.] --- target-i386/translate.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index 53dee79..cd214a6 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -2409,12 +2409,12 @@ static void gen_reset_hflag(DisasContext *s, uint32_t mask) /* Clear BND registers during legacy branches. */ static void gen_bnd_jmp(DisasContext *s) { - /* Do nothing if BND prefix present, MPX is disabled, or if the - BNDREGs are known to be in INIT state already. The helper - itself will check BNDPRESERVE at runtime. */ + /* Clear the registers only if BND prefix is missing, MPX is enabled, + and if the BNDREGs are known to be in use (non-zero) already. + The helper itself will check BNDPRESERVE at runtime. */ if ((s->prefix & PREFIX_REPNZ) == 0 - && (s->flags & HF_MPX_EN_MASK) == 0 - && (s->flags & HF_MPX_IU_MASK) == 0) { + && (s->flags & HF_MPX_EN_MASK) != 0 + && (s->flags & HF_MPX_IU_MASK) != 0) { gen_helper_bnd_jmp(cpu_env); } }