diff mbox

[03/12] mm: Remove VM_FAULT_MINOR

Message ID 100D68C7BA14664A8938383216E40DE0422079B3@FMSMSX114.amr.corp.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Wilcox, Matthew R March 10, 2016, 7:38 p.m. UTC 
You've clearly fixed a bug in xtensa here ;-)  Wonder why nobody noticed that counter was always 0?

+++ b/arch/xtensa/mm/fault.c
@@ -146,7 +146,7 @@ good_area:
 	perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS, 1, regs, address);
 	if (flags & VM_FAULT_MAJOR)
 		perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MAJ, 1, regs, address);
-	else if (flags & VM_FAULT_MINOR)
+	else
 		perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MIN, 1, regs, address);
 
 	return;

Comments

Jan Kara March 10, 2016, 7:48 p.m. UTC | #1 
On Thu 10-03-16 19:38:56, Wilcox, Matthew R wrote:
> You've clearly fixed a bug in xtensa here ;-)  Wonder why nobody noticed
> that counter was always 0?

Likely that architecture is not used too much ;). BTW, I forgot to mention
that patch 4 has been already been merged into Linus' tree today and this
patch is sitting in mm tree. They are unrelated and I was just lazy to
remove them from the series at this point.

								Honza
diff mbox

Patch

diff --git a/include/linux/mm.h b/include/linux/mm.h
index 516e14944339..37f319d7636e 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -1051,8 +1051,6 @@  static inline void clear_page_pfmemalloc(struct page *page)
  * just gets major/minor fault counters bumped up.
  */
 
-#define VM_FAULT_MINOR	0 /* For backwards compat. Remove me quickly. */
-
 #define VM_FAULT_OOM	0x0001
 #define VM_FAULT_SIGBUS	0x0002
 #define VM_FAULT_MAJOR	0x0004