diff mbox

ALSA: mixart: silence unitialized variable warnings

Message ID 20160315070917.GE13560@mwanda (mailing list archive)
State New, archived
Headers show

Commit Message

Dan Carpenter March 15, 2016, 7:09 a.m. UTC 
We print can print the uninitialized memory on error.  Which is an info
leak, I suppose but it's basically harmless.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Comments

Takashi Iwai March 15, 2016, 9:01 a.m. UTC | #1 
On Tue, 15 Mar 2016 08:09:17 +0100,
Dan Carpenter wrote:
> 
> We print can print the uninitialized memory on error.  Which is an info
> leak, I suppose but it's basically harmless.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied, thanks.


Takashi

> 
> diff --git a/sound/pci/mixart/mixart_mixer.c b/sound/pci/mixart/mixart_mixer.c
> index 24a1955..58fd79eb 100644
> --- a/sound/pci/mixart/mixart_mixer.c
> +++ b/sound/pci/mixart/mixart_mixer.c
> @@ -726,7 +726,7 @@ int mixart_update_playback_stream_level(struct snd_mixart* chip, int is_aes, int
>  	int volume[2];
>  	struct mixart_msg request;
>  	struct mixart_set_out_stream_level_req set_level;
> -	u32 status;
> +	u32 status = 0;
>  	struct mixart_pipe *pipe;
>  
>  	memset(&set_level, 0, sizeof(set_level));
> @@ -778,7 +778,7 @@ int mixart_update_capture_stream_level(struct snd_mixart* chip, int is_aes)
>  	struct mixart_pipe *pipe;
>  	struct mixart_msg request;
>  	struct mixart_set_in_audio_level_req set_level;
> -	u32 status;
> +	u32 status = 0;
>  
>  	if(is_aes) {
>  		idx = 1;
>
diff mbox

Patch

diff --git a/sound/pci/mixart/mixart_mixer.c b/sound/pci/mixart/mixart_mixer.c
index 24a1955..58fd79eb 100644
--- a/sound/pci/mixart/mixart_mixer.c
+++ b/sound/pci/mixart/mixart_mixer.c
@@ -726,7 +726,7 @@  int mixart_update_playback_stream_level(struct snd_mixart* chip, int is_aes, int
 	int volume[2];
 	struct mixart_msg request;
 	struct mixart_set_out_stream_level_req set_level;
-	u32 status;
+	u32 status = 0;
 	struct mixart_pipe *pipe;
 
 	memset(&set_level, 0, sizeof(set_level));
@@ -778,7 +778,7 @@  int mixart_update_capture_stream_level(struct snd_mixart* chip, int is_aes)
 	struct mixart_pipe *pipe;
 	struct mixart_msg request;
 	struct mixart_set_in_audio_level_req set_level;
-	u32 status;
+	u32 status = 0;
 
 	if(is_aes) {
 		idx = 1;