[intelddx] TearFree still status "Experimental support"?
diff mbox

Message ID CA+icZUXder2cMvFtBGkRKVEeD-yNXwShjuUMTuiuvZX9HpcKaw@mail.gmail.com
State New
Headers show

Commit Message

Sedat Dilek March 24, 2016, 11:19 a.m. UTC
On Thu, Mar 24, 2016 at 11:56 AM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
> Hi Chris,
>
> is TearFree feature still "experimental" in current xf86-video-intel.git#master?
> It is enabled by default!
>
> [ configure-log ]
> ...
> xf86-video-intel 2.99.917 will be compiled with:
>   Xorg Video ABI version: 15.0 (xorg-server-1.15.1)
>   pixman version: pixman-1-0.30.2
>   Acceleration backends: none *sna uxa
>   Additional debugging support? valgrind
>   Support for Kernel Mode Setting? yes
>   Support for legacy User Mode Setting (for i810)? yes
>   Support for Direct Rendering Infrastructure: *DRI2
>   Support for Xv motion compensation (XvMC and libXvMC): yes
>   Support for display hotplug notifications (udev): yes
>   Build additional tools and utilities? xf86-video-intel-backlight-helper
>   Experimental support: TearFree <--- XXX
> ...
>
> [ configure.ac ]
> ...
> AC_ARG_ENABLE(tear-free,
>      AS_HELP_STRING([--enable-tear-free],
>     [Enable use of TearFree by default [default=no]]),
>      [TEARFREE="$enableval"],
>      [TEARFREE="no"])
> if test "x$TEARFREE" = "xyes"; then
> AC_DEFINE(TEARFREE,1,[Enable "TearFree" by default])
> xp_msg="$xp_msg TearFree" <--- Line needs to be killed ???
> fi
> ...
> if test -n "$xp_msg"; then
> echo "  Experimental support:$xp_msg"
> fi
> ...
>
> Thanks.
>
> - Sedat -
>
> [1] https://cgit.freedesktop.org/xorg/driver/xf86-video-intel/tree/configure.ac#n742
> [2] https://cgit.freedesktop.org/xorg/driver/xf86-video-intel/tree/configure.ac#n927

See attached patch.

- Sedat -

Comments

Sedat Dilek March 30, 2016, 8:44 a.m. UTC | #1
On Thu, Mar 24, 2016 at 12:19 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
> On Thu, Mar 24, 2016 at 11:56 AM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
>> Hi Chris,
>>
>> is TearFree feature still "experimental" in current xf86-video-intel.git#master?
>> It is enabled by default!
>>
>> [ configure-log ]
>> ...
>> xf86-video-intel 2.99.917 will be compiled with:
>>   Xorg Video ABI version: 15.0 (xorg-server-1.15.1)
>>   pixman version: pixman-1-0.30.2
>>   Acceleration backends: none *sna uxa
>>   Additional debugging support? valgrind
>>   Support for Kernel Mode Setting? yes
>>   Support for legacy User Mode Setting (for i810)? yes
>>   Support for Direct Rendering Infrastructure: *DRI2
>>   Support for Xv motion compensation (XvMC and libXvMC): yes
>>   Support for display hotplug notifications (udev): yes
>>   Build additional tools and utilities? xf86-video-intel-backlight-helper
>>   Experimental support: TearFree <--- XXX
>> ...
>>
>> [ configure.ac ]
>> ...
>> AC_ARG_ENABLE(tear-free,
>>      AS_HELP_STRING([--enable-tear-free],
>>     [Enable use of TearFree by default [default=no]]),
>>      [TEARFREE="$enableval"],
>>      [TEARFREE="no"])
>> if test "x$TEARFREE" = "xyes"; then
>> AC_DEFINE(TEARFREE,1,[Enable "TearFree" by default])
>> xp_msg="$xp_msg TearFree" <--- Line needs to be killed ???
>> fi
>> ...
>> if test -n "$xp_msg"; then
>> echo "  Experimental support:$xp_msg"
>> fi
>> ...
>>
>> Thanks.
>>
>> - Sedat -
>>
>> [1] https://cgit.freedesktop.org/xorg/driver/xf86-video-intel/tree/configure.ac#n742
>> [2] https://cgit.freedesktop.org/xorg/driver/xf86-video-intel/tree/configure.ac#n927
>
> See attached patch.
>

Looks like I misread in configure.ac, TearFree is not enabled by default.

[ configure.ac ]

AC_ARG_ENABLE(tear-free,
     AS_HELP_STRING([--enable-tear-free],
    [Enable use of TearFree by default [default=no]]),
     [TEARFREE="$enableval"],
     [TEARFREE="no"])
if test "x$TEARFREE" = "xyes"; then
AC_DEFINE(TEARFREE,1,[Enable "TearFree" by default])
xp_msg="$xp_msg TearFree"
fi

So forget this braino.

- Sedat -

[1] https://cgit.freedesktop.org/xorg/driver/xf86-video-intel/tree/configure.ac#n742

Patch
diff mbox

From 8a65d6d78a2881f715e5fcbc86b236889eb7819a Mon Sep 17 00:00:00 2001
From: Sedat Dilek <sedat.dilek@gmail.com>
Date: Thu, 24 Mar 2016 12:03:49 +0100
Subject: [PATCH] configure: TearFree: Remove "Experimental support" status

Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
 configure.ac | 1 -
 1 file changed, 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index b121515fdf8f..840fb3d96947 100644
--- a/configure.ac
+++ b/configure.ac
@@ -743,7 +743,6 @@  AC_ARG_ENABLE(tear-free,
 	      [TEARFREE="no"])
 if test "x$TEARFREE" = "xyes"; then
 	AC_DEFINE(TEARFREE,1,[Enable "TearFree" by default])
-	xp_msg="$xp_msg TearFree"
 fi
 
 AC_ARG_ENABLE(create2,
-- 
2.7.4