From patchwork Wed Mar 30 09:40:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 8694321 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 8DD99C0553 for ; Wed, 30 Mar 2016 09:41:11 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BFC6620376 for ; Wed, 30 Mar 2016 09:41:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id E7F102035D for ; Wed, 30 Mar 2016 09:41:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 27C166E736; Wed, 30 Mar 2016 09:40:59 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x235.google.com (mail-wm0-x235.google.com [IPv6:2a00:1450:400c:c09::235]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4D0CE6E733 for ; Wed, 30 Mar 2016 09:40:56 +0000 (UTC) Received: by mail-wm0-x235.google.com with SMTP id 127so89851605wmu.1 for ; Wed, 30 Mar 2016 02:40:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+NUf/+9r4M2ZFSzgVobyr2xatnGaqdOU638Ak8qV4f4=; b=A00nFvOEiWz64cOq/V6Q5chgnm721orBFGwLKJ7ULxzlbJhoJm3eek2aOK+PTLXdpD JFXCrN+P2/w9aASaf2BT8KkXT7ASCVH1IHr373uEgQzZAuNAbPuR0B/AnDDLTMTL+X1B QcDtiUWHhq3HfVJNnXu0TVDjUn05przB6rbI8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+NUf/+9r4M2ZFSzgVobyr2xatnGaqdOU638Ak8qV4f4=; b=IXMgQcuOL7fmp0r3ZM+fkGHRDUgy2a24VbXwnaXIFqVS21iuaxHldl+m0Djj3qV3/w UqRiQfMqTy12hDkFhEFQir6A2LPdiXea1QF0ualOGFP2KVX2lrF+cHuCKPX+7kjZpL/X w2rHGv+srjAA8rc0+kS2jKpDu54hJZJ93SMTkKWntUsWbGAYznO5ZqXez07tF5h5Zyh+ nLfu7038H7LZx3KnYxPYfO5oKGNl16Z/Sqb+H94kDezb+a4MdKtctoeGtKwfupu1IgKJ 3Sbbevi9VuqZYF8kXDac1czKLNdAazRLf5Q8BF5iU88KASUs/gqcFdRE+kaQUjIxmf2h nrpg== X-Gm-Message-State: AD7BkJIi5xfSFEBYezSmFgjvw5+xy1L2+9cGicGneIm2px3JKx28A5JDd/3VuJ2PPtKB5g== X-Received: by 10.194.242.202 with SMTP id ws10mr8254798wjc.3.1459330854236; Wed, 30 Mar 2016 02:40:54 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:56b5:0:ac27:b86c:7764:9429]) by smtp.gmail.com with ESMTPSA id v2sm3476437wmd.24.2016.03.30.02.40.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 30 Mar 2016 02:40:53 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 01/13] drm/nouveau: Use unlocked gem unreferencing Date: Wed, 30 Mar 2016 11:40:40 +0200 Message-Id: <1459330852-27668-2-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.8.0.rc3 In-Reply-To: <1459330852-27668-1-git-send-email-daniel.vetter@ffwll.ch> References: <1459330852-27668-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Ben Skeggs , Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP For drm_gem_object_unreference callers are required to hold dev->struct_mutex, which these paths don't. Enforcing this requirement has become a bit more strict with commit ef4c6270bf2867e2f8032e9614d1a8cfc6c71663 Author: Daniel Vetter Date: Thu Oct 15 09:36:25 2015 +0200 drm/gem: Check locking in drm_gem_object_unreference Cc: Ben Skeggs Signed-off-by: Daniel Vetter --- drivers/gpu/drm/nouveau/nouveau_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c index 7ce7fa5cb5e6..816342645f42 100644 --- a/drivers/gpu/drm/nouveau/nouveau_display.c +++ b/drivers/gpu/drm/nouveau/nouveau_display.c @@ -296,7 +296,7 @@ nouveau_user_framebuffer_create(struct drm_device *dev, err: kfree(nouveau_fb); err_unref: - drm_gem_object_unreference(gem); + drm_gem_object_unreference_unlocked(gem); return ERR_PTR(ret); }