From patchwork Wed Mar 30 09:40:41 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 8694331 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 40B029F44D for ; Wed, 30 Mar 2016 09:41:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6AB3020376 for ; Wed, 30 Mar 2016 09:41:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 8814B20361 for ; Wed, 30 Mar 2016 09:41:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C9DE96E73A; Wed, 30 Mar 2016 09:41:00 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x234.google.com (mail-wm0-x234.google.com [IPv6:2a00:1450:400c:c09::234]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3821A6E732 for ; Wed, 30 Mar 2016 09:40:57 +0000 (UTC) Received: by mail-wm0-x234.google.com with SMTP id 191so81974517wmq.0 for ; Wed, 30 Mar 2016 02:40:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=XEoFhZAmHR3GCbrcfLblOmg3oRJR5TUzwygHMBXLgl0=; b=k4tKgh7k6SDukjQxd0iJoZ005DktuhKxO+HSIDpgizP2w2rkVRPYft3jUoL6Nc1Ioc wcaaabYtDOmBkmyPAb4r6I0tUtSndqAhCBGh4XebC0KOUTAuaIs8QbngqatR5rbLtpGV lrVB8QGKz9W9c3IvZ4ROI/UZ9PArc0K84IGTk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=XEoFhZAmHR3GCbrcfLblOmg3oRJR5TUzwygHMBXLgl0=; b=J3eAZbsCrsCq9l9sVFrup5hgS6bFjjju1QSn7S8POGIIixXGG9jabnxT3fHkpE/9i1 NjTJFiKrVUzz/0anoZZY9l/35Gd5eo/p0XkY1iwZtMgmjhPJwD9UqSoK1LoB+GnnlFk7 QEq4cwmqH00vjD5pUo/bM9WmtRj0txhTVlAsy3Yx9cZAs6kBbK5PPa8363hTYvTd4Tid 680CyRhUUIj8fyxI93w4kwXnhR3T8RdL2kwQRvfR+h1tQBoKybSGnyf+fAOMLbC8b9kk m9cXF087GpE2dGi5K0+weDxOkaMbLbeHj8DTX6qZ6gmX9oMcabANCCdyi6hgxP1EaB+i INCQ== X-Gm-Message-State: AD7BkJI2EerD3spodz9R2OxfsfYcoJG2rBdmGq+4g7rLFIWqlX9CtaO3gjqolmlE6haMMg== X-Received: by 10.194.23.67 with SMTP id k3mr7986906wjf.177.1459330855276; Wed, 30 Mar 2016 02:40:55 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:56b5:0:ac27:b86c:7764:9429]) by smtp.gmail.com with ESMTPSA id v2sm3476437wmd.24.2016.03.30.02.40.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 30 Mar 2016 02:40:54 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 02/13] drm/omapdrm: Use unlocked gem unreferencing Date: Wed, 30 Mar 2016 11:40:41 +0200 Message-Id: <1459330852-27668-3-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.8.0.rc3 In-Reply-To: <1459330852-27668-1-git-send-email-daniel.vetter@ffwll.ch> References: <1459330852-27668-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Tomi Valkeinen , Laurent Pinchart , Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP For drm_gem_object_unreference callers are required to hold dev->struct_mutex, which these paths don't. Enforcing this requirement has become a bit more strict with commit ef4c6270bf2867e2f8032e9614d1a8cfc6c71663 Author: Daniel Vetter Date: Thu Oct 15 09:36:25 2015 +0200 drm/gem: Check locking in drm_gem_object_unreference Cc: Tomi Valkeinen Cc: Laurent Pinchart Signed-off-by: Daniel Vetter Acked-by: Tomi Valkeinen Acked-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c index 3cb16f0cf381..89da41ac64d2 100644 --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c @@ -153,7 +153,7 @@ static int omap_fbdev_create(struct drm_fb_helper *helper, /* note: if fb creation failed, we can't rely on fb destroy * to unref the bo: */ - drm_gem_object_unreference(fbdev->bo); + drm_gem_object_unreference_unlocked(fbdev->bo); ret = PTR_ERR(fb); goto fail; }