drm/i915: Read DPCD when connector forced on.
diff mbox

Message ID 1459527646-9083-1-git-send-email-bob.j.paauwe@intel.com
State New
Headers show

Commit Message

Bob Paauwe April 1, 2016, 4:20 p.m. UTC
When a DP connector is forced on using using the video=<connector>:e
kernel command line, we bypass the calls to check if the port is
connected and also bypass the call to intel_dp_detect_dpcd();  The
result is that we don't query for the sink capabilities like the
max link bandwidth.  The sink capabilities are needed to set a
mode.

The solution is to add a call to intel_dp_detect_dpcd() in the code
path for forced on DP connectors.

Signed-off-by: Bob Paauwe <bob.j.paauwe@intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Bob Paauwe April 1, 2016, 5:53 p.m. UTC | #1
On Fri, 1 Apr 2016 17:03:37 +0000
Patchwork <patchwork@emeril.freedesktop.org> wrote:

> == Series Details ==
> 
> Series: drm/i915: Read DPCD when connector forced on.
> URL   : https://patchwork.freedesktop.org/series/5185/
> State : failure
> 
> == Summary ==
> 
> Series 5185v1 drm/i915: Read DPCD when connector forced on.
> http://patchwork.freedesktop.org/api/1.0/series/5185/revisions/1/mbox/
> 
> Test kms_flip:
>         Subgroup basic-flip-vs-modeset:
>                 pass       -> DMESG-WARN (ilk-hp8440p) UNSTABLE
Unrelated: CPU pipe A FIFO underrun and test is not using DP ports.

>         Subgroup basic-flip-vs-wf_vblank:
>                 pass       -> FAIL       (snb-x220t)
Failure is on vga connector so unrelated to code change in DP code.

> Test kms_force_connector_basic:
>         Subgroup force-edid:
>                 skip       -> PASS       (ivb-t430s)
> 
> bdw-nuci7        total:196  pass:184  dwarn:0   dfail:0   fail:0   skip:12 
> bdw-ultra        total:196  pass:175  dwarn:0   dfail:0   fail:0   skip:21 
> bsw-nuc-2        total:196  pass:159  dwarn:0   dfail:0   fail:0   skip:37 
> byt-nuc          total:196  pass:161  dwarn:0   dfail:0   fail:0   skip:35 
> hsw-brixbox      total:196  pass:174  dwarn:0   dfail:0   fail:0   skip:22 
> hsw-gt2          total:196  pass:179  dwarn:0   dfail:0   fail:0   skip:17 
> ilk-hp8440p      total:196  pass:131  dwarn:1   dfail:0   fail:0   skip:64 
> ivb-t430s        total:196  pass:171  dwarn:0   dfail:0   fail:0   skip:25 
> skl-i7k-2        total:196  pass:173  dwarn:0   dfail:0   fail:0   skip:23 
> skl-nuci5        total:196  pass:185  dwarn:0   dfail:0   fail:0   skip:11 
> snb-dellxps      total:196  pass:162  dwarn:0   dfail:0   fail:0   skip:34 
> snb-x220t        total:196  pass:161  dwarn:0   dfail:0   fail:2   skip:33 
> 
> Results at /archive/results/CI_IGT_test/Patchwork_1778/
> 
> 38b47023a604068e2a222ac166f5f8ef7d56e352 drm-intel-nightly: 2016y-04m-01d-12h-04m-08s UTC integration manifest
> a73fbb388ca70b2ca76c82124fde009c47cc33cd drm/i915: Read DPCD when connector forced on.
>

Patch
diff mbox

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 8aa9214..39b7f6d 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -4644,6 +4644,8 @@  intel_dp_force(struct drm_connector *connector)
 	power_domain = intel_display_port_aux_power_domain(intel_encoder);
 	intel_display_power_get(dev_priv, power_domain);
 
+	intel_dp_detect_dpcd(intel_dp);
+
 	intel_dp_set_edid(intel_dp);
 
 	intel_display_power_put(dev_priv, power_domain);