| Message ID | 1459616174-31557-2-git-send-email-tytso@mit.edu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, Apr 02, 2016 at 12:56:14PM -0400, Theodore Ts'o wrote: > Signed-off-by: Theodore Ts'o <tytso@mit.edu> > --- > common/rc | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/common/rc b/common/rc > index 2ccca3b..961601b 100644 > --- a/common/rc > +++ b/common/rc > @@ -1916,6 +1916,10 @@ _require_xfs_db_command() > # check that kernel and filesystem support direct I/O > _require_odirect() > { > + if [ $FSTYP = "ext4" ] && > + echo "$MOUNT_OPTIONS" | grep -q "test_dummy_encryption" ; then > + _notrun "ext4 encryption doesn't support O_DIRECT" > + fi > testfile=$TEST_DIR/$$.direct > $XFS_IO_PROG -F -f -d -c "pwrite 0 20k" $testfile > /dev/null 2>&1 Why isn't the direct IO failing here with an error sufficient to prevent the test from running? Cheers, Dave.
diff --git a/common/rc b/common/rc index 2ccca3b..961601b 100644 --- a/common/rc +++ b/common/rc @@ -1916,6 +1916,10 @@ _require_xfs_db_command() # check that kernel and filesystem support direct I/O _require_odirect() { + if [ $FSTYP = "ext4" ] && + echo "$MOUNT_OPTIONS" | grep -q "test_dummy_encryption" ; then + _notrun "ext4 encryption doesn't support O_DIRECT" + fi testfile=$TEST_DIR/$$.direct $XFS_IO_PROG -F -f -d -c "pwrite 0 20k" $testfile > /dev/null 2>&1 if [ $? -ne 0 ]; then
Signed-off-by: Theodore Ts'o <tytso@mit.edu> --- common/rc | 4 ++++ 1 file changed, 4 insertions(+)