mmc: Remove some redundant debug prints
diff mbox

Message ID 5cddc2f870eccf8cf50d463c72d2908dad9e1017.1459942344.git.baolin.wang@linaro.org
State New
Headers show

Commit Message

Baolin Wang April 6, 2016, 11:38 a.m. UTC
This patch removes some redundant debug prints, since we have added some
tracepoints to help with performance analysis of MMC subsystem.

Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
---
 drivers/mmc/core/core.c |   52 -----------------------------------------------
 1 file changed, 52 deletions(-)

Comments

Jisheng Zhang April 6, 2016, 11:57 a.m. UTC | #1
On Wed,  6 Apr 2016 19:38:30 +0800 Baolin Wang wrote:

> This patch removes some redundant debug prints, since we have added some
> tracepoints to help with performance analysis of MMC subsystem.

I think the debug prints you removed are useful for debugging mmc err, how is
this purpose achieved by tracepoints? From another side, why should I enable
tracepoints to debug mmc err?

Thanks

> 
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> ---
>  drivers/mmc/core/core.c |   52 -----------------------------------------------
>  1 file changed, 52 deletions(-)
> 
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index f80b3ab..3f1362a 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -157,33 +157,6 @@ void mmc_request_done(struct mmc_host *host, struct mmc_request *mrq)
>  
>  		led_trigger_event(host->led, LED_OFF);
>  
> -		if (mrq->sbc) {
> -			pr_debug("%s: req done <CMD%u>: %d: %08x %08x %08x %08x\n",
> -				mmc_hostname(host), mrq->sbc->opcode,
> -				mrq->sbc->error,
> -				mrq->sbc->resp[0], mrq->sbc->resp[1],
> -				mrq->sbc->resp[2], mrq->sbc->resp[3]);
> -		}
> -
> -		pr_debug("%s: req done (CMD%u): %d: %08x %08x %08x %08x\n",
> -			mmc_hostname(host), cmd->opcode, err,
> -			cmd->resp[0], cmd->resp[1],
> -			cmd->resp[2], cmd->resp[3]);
> -
> -		if (mrq->data) {
> -			pr_debug("%s:     %d bytes transferred: %d\n",
> -				mmc_hostname(host),
> -				mrq->data->bytes_xfered, mrq->data->error);
> -		}
> -
> -		if (mrq->stop) {
> -			pr_debug("%s:     (CMD%u): %d: %08x %08x %08x %08x\n",
> -				mmc_hostname(host), mrq->stop->opcode,
> -				mrq->stop->error,
> -				mrq->stop->resp[0], mrq->stop->resp[1],
> -				mrq->stop->resp[2], mrq->stop->resp[3]);
> -		}
> -
>  		if (mrq->done)
>  			mrq->done(mrq);
>  	}
> @@ -236,31 +209,6 @@ static int mmc_start_request(struct mmc_host *host, struct mmc_request *mrq)
>  	if (mmc_card_removed(host->card))
>  		return -ENOMEDIUM;
>  
> -	if (mrq->sbc) {
> -		pr_debug("<%s: starting CMD%u arg %08x flags %08x>\n",
> -			 mmc_hostname(host), mrq->sbc->opcode,
> -			 mrq->sbc->arg, mrq->sbc->flags);
> -	}
> -
> -	pr_debug("%s: starting CMD%u arg %08x flags %08x\n",
> -		 mmc_hostname(host), mrq->cmd->opcode,
> -		 mrq->cmd->arg, mrq->cmd->flags);
> -
> -	if (mrq->data) {
> -		pr_debug("%s:     blksz %d blocks %d flags %08x "
> -			"tsac %d ms nsac %d\n",
> -			mmc_hostname(host), mrq->data->blksz,
> -			mrq->data->blocks, mrq->data->flags,
> -			mrq->data->timeout_ns / 1000000,
> -			mrq->data->timeout_clks);
> -	}
> -
> -	if (mrq->stop) {
> -		pr_debug("%s:     CMD%u arg %08x flags %08x\n",
> -			 mmc_hostname(host), mrq->stop->opcode,
> -			 mrq->stop->arg, mrq->stop->flags);
> -	}
> -
>  	WARN_ON(!host->claimed);
>  
>  	mrq->cmd->error = 0;

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jaehoon Chung April 7, 2016, 1:40 a.m. UTC | #2
On 04/06/2016 08:57 PM, Jisheng Zhang wrote:
> 
> 
> On Wed,  6 Apr 2016 19:38:30 +0800 Baolin Wang wrote:
> 
>> This patch removes some redundant debug prints, since we have added some
>> tracepoints to help with performance analysis of MMC subsystem.
> 
> I think the debug prints you removed are useful for debugging mmc err, how is
> this purpose achieved by tracepoints? From another side, why should I enable
> tracepoints to debug mmc err?

I agreed Jisheng's opinion. tracepoint is helpful for analyzing performance and debugging something.
But I think it's more easier to check the mmc error at booting time or some time.

Best Regards,
Jaehoon Chung

> 
> Thanks
> 
>>
>> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
>> ---
>>  drivers/mmc/core/core.c |   52 -----------------------------------------------
>>  1 file changed, 52 deletions(-)
>>
>> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
>> index f80b3ab..3f1362a 100644
>> --- a/drivers/mmc/core/core.c
>> +++ b/drivers/mmc/core/core.c
>> @@ -157,33 +157,6 @@ void mmc_request_done(struct mmc_host *host, struct mmc_request *mrq)
>>  
>>  		led_trigger_event(host->led, LED_OFF);
>>  
>> -		if (mrq->sbc) {
>> -			pr_debug("%s: req done <CMD%u>: %d: %08x %08x %08x %08x\n",
>> -				mmc_hostname(host), mrq->sbc->opcode,
>> -				mrq->sbc->error,
>> -				mrq->sbc->resp[0], mrq->sbc->resp[1],
>> -				mrq->sbc->resp[2], mrq->sbc->resp[3]);
>> -		}
>> -
>> -		pr_debug("%s: req done (CMD%u): %d: %08x %08x %08x %08x\n",
>> -			mmc_hostname(host), cmd->opcode, err,
>> -			cmd->resp[0], cmd->resp[1],
>> -			cmd->resp[2], cmd->resp[3]);
>> -
>> -		if (mrq->data) {
>> -			pr_debug("%s:     %d bytes transferred: %d\n",
>> -				mmc_hostname(host),
>> -				mrq->data->bytes_xfered, mrq->data->error);
>> -		}
>> -
>> -		if (mrq->stop) {
>> -			pr_debug("%s:     (CMD%u): %d: %08x %08x %08x %08x\n",
>> -				mmc_hostname(host), mrq->stop->opcode,
>> -				mrq->stop->error,
>> -				mrq->stop->resp[0], mrq->stop->resp[1],
>> -				mrq->stop->resp[2], mrq->stop->resp[3]);
>> -		}
>> -
>>  		if (mrq->done)
>>  			mrq->done(mrq);
>>  	}
>> @@ -236,31 +209,6 @@ static int mmc_start_request(struct mmc_host *host, struct mmc_request *mrq)
>>  	if (mmc_card_removed(host->card))
>>  		return -ENOMEDIUM;
>>  
>> -	if (mrq->sbc) {
>> -		pr_debug("<%s: starting CMD%u arg %08x flags %08x>\n",
>> -			 mmc_hostname(host), mrq->sbc->opcode,
>> -			 mrq->sbc->arg, mrq->sbc->flags);
>> -	}
>> -
>> -	pr_debug("%s: starting CMD%u arg %08x flags %08x\n",
>> -		 mmc_hostname(host), mrq->cmd->opcode,
>> -		 mrq->cmd->arg, mrq->cmd->flags);
>> -
>> -	if (mrq->data) {
>> -		pr_debug("%s:     blksz %d blocks %d flags %08x "
>> -			"tsac %d ms nsac %d\n",
>> -			mmc_hostname(host), mrq->data->blksz,
>> -			mrq->data->blocks, mrq->data->flags,
>> -			mrq->data->timeout_ns / 1000000,
>> -			mrq->data->timeout_clks);
>> -	}
>> -
>> -	if (mrq->stop) {
>> -		pr_debug("%s:     CMD%u arg %08x flags %08x\n",
>> -			 mmc_hostname(host), mrq->stop->opcode,
>> -			 mrq->stop->arg, mrq->stop->flags);
>> -	}
>> -
>>  	WARN_ON(!host->claimed);
>>  
>>  	mrq->cmd->error = 0;
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Baolin Wang April 7, 2016, 3:13 a.m. UTC | #3
On 6 April 2016 at 19:57, Jisheng Zhang <jszhang@marvell.com> wrote:
>
>
> On Wed,  6 Apr 2016 19:38:30 +0800 Baolin Wang wrote:
>
>> This patch removes some redundant debug prints, since we have added some
>> tracepoints to help with performance analysis of MMC subsystem.
>
> I think the debug prints you removed are useful for debugging mmc err, how is
> this purpose achieved by tracepoints? From another side, why should I enable
> tracepoints to debug mmc err?

Tracepoints can show all the debugging mmc information, so I think
these debug prints are redundant. Another point you said, why you
should enable tracepoints to debug mmc? Tracepoints are lightweight
hooks and one simple way to be used for tracing and performance
accounting.

>
> Thanks
>
>>
>> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
>> ---
>>  drivers/mmc/core/core.c |   52 -----------------------------------------------
>>  1 file changed, 52 deletions(-)
>>
>> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
>> index f80b3ab..3f1362a 100644
>> --- a/drivers/mmc/core/core.c
>> +++ b/drivers/mmc/core/core.c
>> @@ -157,33 +157,6 @@ void mmc_request_done(struct mmc_host *host, struct mmc_request *mrq)
>>
>>               led_trigger_event(host->led, LED_OFF);
>>
>> -             if (mrq->sbc) {
>> -                     pr_debug("%s: req done <CMD%u>: %d: %08x %08x %08x %08x\n",
>> -                             mmc_hostname(host), mrq->sbc->opcode,
>> -                             mrq->sbc->error,
>> -                             mrq->sbc->resp[0], mrq->sbc->resp[1],
>> -                             mrq->sbc->resp[2], mrq->sbc->resp[3]);
>> -             }
>> -
>> -             pr_debug("%s: req done (CMD%u): %d: %08x %08x %08x %08x\n",
>> -                     mmc_hostname(host), cmd->opcode, err,
>> -                     cmd->resp[0], cmd->resp[1],
>> -                     cmd->resp[2], cmd->resp[3]);
>> -
>> -             if (mrq->data) {
>> -                     pr_debug("%s:     %d bytes transferred: %d\n",
>> -                             mmc_hostname(host),
>> -                             mrq->data->bytes_xfered, mrq->data->error);
>> -             }
>> -
>> -             if (mrq->stop) {
>> -                     pr_debug("%s:     (CMD%u): %d: %08x %08x %08x %08x\n",
>> -                             mmc_hostname(host), mrq->stop->opcode,
>> -                             mrq->stop->error,
>> -                             mrq->stop->resp[0], mrq->stop->resp[1],
>> -                             mrq->stop->resp[2], mrq->stop->resp[3]);
>> -             }
>> -
>>               if (mrq->done)
>>                       mrq->done(mrq);
>>       }
>> @@ -236,31 +209,6 @@ static int mmc_start_request(struct mmc_host *host, struct mmc_request *mrq)
>>       if (mmc_card_removed(host->card))
>>               return -ENOMEDIUM;
>>
>> -     if (mrq->sbc) {
>> -             pr_debug("<%s: starting CMD%u arg %08x flags %08x>\n",
>> -                      mmc_hostname(host), mrq->sbc->opcode,
>> -                      mrq->sbc->arg, mrq->sbc->flags);
>> -     }
>> -
>> -     pr_debug("%s: starting CMD%u arg %08x flags %08x\n",
>> -              mmc_hostname(host), mrq->cmd->opcode,
>> -              mrq->cmd->arg, mrq->cmd->flags);
>> -
>> -     if (mrq->data) {
>> -             pr_debug("%s:     blksz %d blocks %d flags %08x "
>> -                     "tsac %d ms nsac %d\n",
>> -                     mmc_hostname(host), mrq->data->blksz,
>> -                     mrq->data->blocks, mrq->data->flags,
>> -                     mrq->data->timeout_ns / 1000000,
>> -                     mrq->data->timeout_clks);
>> -     }
>> -
>> -     if (mrq->stop) {
>> -             pr_debug("%s:     CMD%u arg %08x flags %08x\n",
>> -                      mmc_hostname(host), mrq->stop->opcode,
>> -                      mrq->stop->arg, mrq->stop->flags);
>> -     }
>> -
>>       WARN_ON(!host->claimed);
>>
>>       mrq->cmd->error = 0;
>
Baolin Wang April 7, 2016, 3:15 a.m. UTC | #4
On 7 April 2016 at 09:40, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> On 04/06/2016 08:57 PM, Jisheng Zhang wrote:
>>
>>
>> On Wed,  6 Apr 2016 19:38:30 +0800 Baolin Wang wrote:
>>
>>> This patch removes some redundant debug prints, since we have added some
>>> tracepoints to help with performance analysis of MMC subsystem.
>>
>> I think the debug prints you removed are useful for debugging mmc err, how is
>> this purpose achieved by tracepoints? From another side, why should I enable
>> tracepoints to debug mmc err?
>
> I agreed Jisheng's opinion. tracepoint is helpful for analyzing performance and debugging something.
> But I think it's more easier to check the mmc error at booting time or some time.

OK. Sounds reasonable.

>
> Best Regards,
> Jaehoon Chung
>
>>
>> Thanks
>>
>>>
>>> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
>>> ---
>>>  drivers/mmc/core/core.c |   52 -----------------------------------------------
>>>  1 file changed, 52 deletions(-)
>>>
>>> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
>>> index f80b3ab..3f1362a 100644
>>> --- a/drivers/mmc/core/core.c
>>> +++ b/drivers/mmc/core/core.c
>>> @@ -157,33 +157,6 @@ void mmc_request_done(struct mmc_host *host, struct mmc_request *mrq)
>>>
>>>              led_trigger_event(host->led, LED_OFF);
>>>
>>> -            if (mrq->sbc) {
>>> -                    pr_debug("%s: req done <CMD%u>: %d: %08x %08x %08x %08x\n",
>>> -                            mmc_hostname(host), mrq->sbc->opcode,
>>> -                            mrq->sbc->error,
>>> -                            mrq->sbc->resp[0], mrq->sbc->resp[1],
>>> -                            mrq->sbc->resp[2], mrq->sbc->resp[3]);
>>> -            }
>>> -
>>> -            pr_debug("%s: req done (CMD%u): %d: %08x %08x %08x %08x\n",
>>> -                    mmc_hostname(host), cmd->opcode, err,
>>> -                    cmd->resp[0], cmd->resp[1],
>>> -                    cmd->resp[2], cmd->resp[3]);
>>> -
>>> -            if (mrq->data) {
>>> -                    pr_debug("%s:     %d bytes transferred: %d\n",
>>> -                            mmc_hostname(host),
>>> -                            mrq->data->bytes_xfered, mrq->data->error);
>>> -            }
>>> -
>>> -            if (mrq->stop) {
>>> -                    pr_debug("%s:     (CMD%u): %d: %08x %08x %08x %08x\n",
>>> -                            mmc_hostname(host), mrq->stop->opcode,
>>> -                            mrq->stop->error,
>>> -                            mrq->stop->resp[0], mrq->stop->resp[1],
>>> -                            mrq->stop->resp[2], mrq->stop->resp[3]);
>>> -            }
>>> -
>>>              if (mrq->done)
>>>                      mrq->done(mrq);
>>>      }
>>> @@ -236,31 +209,6 @@ static int mmc_start_request(struct mmc_host *host, struct mmc_request *mrq)
>>>      if (mmc_card_removed(host->card))
>>>              return -ENOMEDIUM;
>>>
>>> -    if (mrq->sbc) {
>>> -            pr_debug("<%s: starting CMD%u arg %08x flags %08x>\n",
>>> -                     mmc_hostname(host), mrq->sbc->opcode,
>>> -                     mrq->sbc->arg, mrq->sbc->flags);
>>> -    }
>>> -
>>> -    pr_debug("%s: starting CMD%u arg %08x flags %08x\n",
>>> -             mmc_hostname(host), mrq->cmd->opcode,
>>> -             mrq->cmd->arg, mrq->cmd->flags);
>>> -
>>> -    if (mrq->data) {
>>> -            pr_debug("%s:     blksz %d blocks %d flags %08x "
>>> -                    "tsac %d ms nsac %d\n",
>>> -                    mmc_hostname(host), mrq->data->blksz,
>>> -                    mrq->data->blocks, mrq->data->flags,
>>> -                    mrq->data->timeout_ns / 1000000,
>>> -                    mrq->data->timeout_clks);
>>> -    }
>>> -
>>> -    if (mrq->stop) {
>>> -            pr_debug("%s:     CMD%u arg %08x flags %08x\n",
>>> -                     mmc_hostname(host), mrq->stop->opcode,
>>> -                     mrq->stop->arg, mrq->stop->flags);
>>> -    }
>>> -
>>>      WARN_ON(!host->claimed);
>>>
>>>      mrq->cmd->error = 0;
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>>
>

Patch
diff mbox

diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index f80b3ab..3f1362a 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -157,33 +157,6 @@  void mmc_request_done(struct mmc_host *host, struct mmc_request *mrq)
 
 		led_trigger_event(host->led, LED_OFF);
 
-		if (mrq->sbc) {
-			pr_debug("%s: req done <CMD%u>: %d: %08x %08x %08x %08x\n",
-				mmc_hostname(host), mrq->sbc->opcode,
-				mrq->sbc->error,
-				mrq->sbc->resp[0], mrq->sbc->resp[1],
-				mrq->sbc->resp[2], mrq->sbc->resp[3]);
-		}
-
-		pr_debug("%s: req done (CMD%u): %d: %08x %08x %08x %08x\n",
-			mmc_hostname(host), cmd->opcode, err,
-			cmd->resp[0], cmd->resp[1],
-			cmd->resp[2], cmd->resp[3]);
-
-		if (mrq->data) {
-			pr_debug("%s:     %d bytes transferred: %d\n",
-				mmc_hostname(host),
-				mrq->data->bytes_xfered, mrq->data->error);
-		}
-
-		if (mrq->stop) {
-			pr_debug("%s:     (CMD%u): %d: %08x %08x %08x %08x\n",
-				mmc_hostname(host), mrq->stop->opcode,
-				mrq->stop->error,
-				mrq->stop->resp[0], mrq->stop->resp[1],
-				mrq->stop->resp[2], mrq->stop->resp[3]);
-		}
-
 		if (mrq->done)
 			mrq->done(mrq);
 	}
@@ -236,31 +209,6 @@  static int mmc_start_request(struct mmc_host *host, struct mmc_request *mrq)
 	if (mmc_card_removed(host->card))
 		return -ENOMEDIUM;
 
-	if (mrq->sbc) {
-		pr_debug("<%s: starting CMD%u arg %08x flags %08x>\n",
-			 mmc_hostname(host), mrq->sbc->opcode,
-			 mrq->sbc->arg, mrq->sbc->flags);
-	}
-
-	pr_debug("%s: starting CMD%u arg %08x flags %08x\n",
-		 mmc_hostname(host), mrq->cmd->opcode,
-		 mrq->cmd->arg, mrq->cmd->flags);
-
-	if (mrq->data) {
-		pr_debug("%s:     blksz %d blocks %d flags %08x "
-			"tsac %d ms nsac %d\n",
-			mmc_hostname(host), mrq->data->blksz,
-			mrq->data->blocks, mrq->data->flags,
-			mrq->data->timeout_ns / 1000000,
-			mrq->data->timeout_clks);
-	}
-
-	if (mrq->stop) {
-		pr_debug("%s:     CMD%u arg %08x flags %08x\n",
-			 mmc_hostname(host), mrq->stop->opcode,
-			 mrq->stop->arg, mrq->stop->flags);
-	}
-
 	WARN_ON(!host->claimed);
 
 	mrq->cmd->error = 0;