From patchwork Wed Apr 6 11:38:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "(Exiting) Baolin Wang" X-Patchwork-Id: 8761441 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A17509F36E for ; Wed, 6 Apr 2016 11:39:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C1E79201EF for ; Wed, 6 Apr 2016 11:39:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D0951201D3 for ; Wed, 6 Apr 2016 11:39:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752671AbcDFLjc (ORCPT ); Wed, 6 Apr 2016 07:39:32 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:34820 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751553AbcDFLjb (ORCPT ); Wed, 6 Apr 2016 07:39:31 -0400 Received: by mail-pf0-f180.google.com with SMTP id n1so31894711pfn.2 for ; Wed, 06 Apr 2016 04:39:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=h3OWwP4A/TFkKvPep1KttyNwK34MhklaQi0HKy5dn7M=; b=S327VUTtzBgWkPRgAhtlBGmgl2hVkD+sh9uRPH/aZghfI5HPDh+lHPWD5uBUUjpCAE 4JnueSK1gofOvvhHH//UNzEIAfhgDc1F0cVIcJhSZqwbH/kMAnUjEQb0x88dmsmNp99Z l2rt0Lrz5YbEoymWQCKXt+6vemPT7yXEgVcrs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=h3OWwP4A/TFkKvPep1KttyNwK34MhklaQi0HKy5dn7M=; b=kAur2ky7eDcf68fCPzKKWOkvdMI19+77OVSRw2qc5nZ5LWQTRDRVHcV1s4da2mYyu3 DrBS7R1v2aJfUQ3OyeOfvlJqYb8GsrnzmFlnpsunZ+vF9P2t3cm6DYX5GBHTueDf2+Ex aF5rJoKpH9OfsFTAt82ZrV+0+o3IACBaDysFF2ZV0x4cSWHzTjcGzjZgw8CZnFZAzjpF zt9kl5SI53YDWZyeOSLxKkBp8e8/ksnD5/jhOis87UH1iJgqfNOhfVss8g7BoRvDsWtv LTm4WmvqGUAGxtl/unyiwErec77NlKs9oWU1vfli0+oFTRWSPI3OXZ35uUe7Imwk1DIU fokQ== X-Gm-Message-State: AD7BkJLh/Gi6UNt5NDuLWuAKK8SafGYeJStvk/lYTZpCxE2s+BgxgHJnPsbvRs1nbYbllIRG X-Received: by 10.98.33.91 with SMTP id h88mr37049374pfh.54.1459942770789; Wed, 06 Apr 2016 04:39:30 -0700 (PDT) Received: from baolinwangubtpc.spreadtrum.com ([175.111.195.49]) by smtp.gmail.com with ESMTPSA id f65sm4449280pfd.47.2016.04.06.04.39.27 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 06 Apr 2016 04:39:30 -0700 (PDT) From: Baolin Wang To: ulf.hansson@linaro.org Cc: adrian.hunter@intel.com, rmk+kernel@arm.linux.org.uk, shawn.lin@rock-chips.com, dianders@chromium.org, david@protonic.nl, broonie@kernel.org, linus.walleij@linaro.org, takahiro.akashi@linaro.org, baolin.wang@linaro.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org Subject: [PATCH] mmc: Remove some redundant debug prints Date: Wed, 6 Apr 2016 19:38:30 +0800 Message-Id: <5cddc2f870eccf8cf50d463c72d2908dad9e1017.1459942344.git.baolin.wang@linaro.org> X-Mailer: git-send-email 1.7.9.5 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch removes some redundant debug prints, since we have added some tracepoints to help with performance analysis of MMC subsystem. Signed-off-by: Baolin Wang --- drivers/mmc/core/core.c | 52 ----------------------------------------------- 1 file changed, 52 deletions(-) diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index f80b3ab..3f1362a 100644 --- a/drivers/mmc/core/core.c +++ b/drivers/mmc/core/core.c @@ -157,33 +157,6 @@ void mmc_request_done(struct mmc_host *host, struct mmc_request *mrq) led_trigger_event(host->led, LED_OFF); - if (mrq->sbc) { - pr_debug("%s: req done : %d: %08x %08x %08x %08x\n", - mmc_hostname(host), mrq->sbc->opcode, - mrq->sbc->error, - mrq->sbc->resp[0], mrq->sbc->resp[1], - mrq->sbc->resp[2], mrq->sbc->resp[3]); - } - - pr_debug("%s: req done (CMD%u): %d: %08x %08x %08x %08x\n", - mmc_hostname(host), cmd->opcode, err, - cmd->resp[0], cmd->resp[1], - cmd->resp[2], cmd->resp[3]); - - if (mrq->data) { - pr_debug("%s: %d bytes transferred: %d\n", - mmc_hostname(host), - mrq->data->bytes_xfered, mrq->data->error); - } - - if (mrq->stop) { - pr_debug("%s: (CMD%u): %d: %08x %08x %08x %08x\n", - mmc_hostname(host), mrq->stop->opcode, - mrq->stop->error, - mrq->stop->resp[0], mrq->stop->resp[1], - mrq->stop->resp[2], mrq->stop->resp[3]); - } - if (mrq->done) mrq->done(mrq); } @@ -236,31 +209,6 @@ static int mmc_start_request(struct mmc_host *host, struct mmc_request *mrq) if (mmc_card_removed(host->card)) return -ENOMEDIUM; - if (mrq->sbc) { - pr_debug("<%s: starting CMD%u arg %08x flags %08x>\n", - mmc_hostname(host), mrq->sbc->opcode, - mrq->sbc->arg, mrq->sbc->flags); - } - - pr_debug("%s: starting CMD%u arg %08x flags %08x\n", - mmc_hostname(host), mrq->cmd->opcode, - mrq->cmd->arg, mrq->cmd->flags); - - if (mrq->data) { - pr_debug("%s: blksz %d blocks %d flags %08x " - "tsac %d ms nsac %d\n", - mmc_hostname(host), mrq->data->blksz, - mrq->data->blocks, mrq->data->flags, - mrq->data->timeout_ns / 1000000, - mrq->data->timeout_clks); - } - - if (mrq->stop) { - pr_debug("%s: CMD%u arg %08x flags %08x\n", - mmc_hostname(host), mrq->stop->opcode, - mrq->stop->arg, mrq->stop->flags); - } - WARN_ON(!host->claimed); mrq->cmd->error = 0;