From patchwork Sat Apr 9 11:19:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Wilson X-Patchwork-Id: 8788011 Return-Path: X-Original-To: patchwork-intel-gfx@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 392529FC82 for ; Sat, 9 Apr 2016 11:19:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3612E20328 for ; Sat, 9 Apr 2016 11:19:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 23B75202AE for ; Sat, 9 Apr 2016 11:19:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 86CD06E427; Sat, 9 Apr 2016 11:19:23 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id A7BB96E42A for ; Sat, 9 Apr 2016 11:19:22 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id l6so9896408wml.3 for ; Sat, 09 Apr 2016 04:19:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=yivm7XuEmTHTBflPRnLIR1yiiUw25S/UIWwwUt1ajLk=; b=B5epzHQWPQLbX8hlVKLJXqqAB6lZjlGZPHxK4ThZuNiMfIbfqGGmH1uVU/0hq4qy6W uZDvFhqxsJZsCtRIm0KXRPu9CuToFO4YCOpT1bn39F494bQLzDdT7v1jx632uHstWEJK 4+MPqWqqC6dFthJpsMx02Or0xL7KdABJ9UwB1sOEwFp+PxMx4CIv0RUKZSCSgOdXxssd AXFOmh2dj931jTfBIGjZgLS7WlVvc9JQfNqyS1w2uKmF+HGzUb/BaHR4ltcez723QajJ 9IDrC/ghaNTMkHa+MCaZ+6bFuBX0QQ9EkxmRkHosxO6a4OJ2ZZakcfZyUZgFODfbBdwQ BoSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=yivm7XuEmTHTBflPRnLIR1yiiUw25S/UIWwwUt1ajLk=; b=aabl8IGFd4+uL6ntvCxVxT6d5+jFpm6nu7JM7fOYFqFH+gsDYSqnieoFky9UspbVjN CoW7JDOh2XjNI8+w213IDZ08yOSP5WcdRxLqNei92FdaBJOeNTFCQeQOWj4juiFfaFD9 7chBxe2RYr6HVt5lplsRiR1ljY+yo8zt/aKz2GTHA48/P3nN4amSVFAePbWVd31vwch7 EavPwNEPzRtYPSYQSFmFWxa9W+OKNWBeyeoER6VUyFzFU830pTiPdu/OecHD3YWwOrMk CFwmz4YSp7CWx+dGEpZ/tM1ss06lG3+9oLtGQmiaat3vyQTxj12gQUkSomDslRq9eknv n0hA== X-Gm-Message-State: AD7BkJIvD9FGhNfhasfqIA9JzrMEOXBAQSeP2uLtkSilVNXAq75iI9BUyxb+SLp/8xPyDw== X-Received: by 10.194.248.135 with SMTP id ym7mr14362486wjc.174.1460200761382; Sat, 09 Apr 2016 04:19:21 -0700 (PDT) Received: from haswell.alporthouse.com ([78.156.65.138]) by smtp.gmail.com with ESMTPSA id a1sm17656557wje.43.2016.04.09.04.19.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 09 Apr 2016 04:19:20 -0700 (PDT) From: Chris Wilson To: intel-gfx@lists.freedesktop.org Date: Sat, 9 Apr 2016 12:19:04 +0100 Message-Id: <1460200753-28466-2-git-send-email-chris@chris-wilson.co.uk> X-Mailer: git-send-email 2.8.0.rc3 In-Reply-To: <1460200753-28466-1-git-send-email-chris@chris-wilson.co.uk> References: <1460200753-28466-1-git-send-email-chris@chris-wilson.co.uk> Cc: Jani Nikula Subject: [Intel-gfx] [PATCH 01/10] drm/i915: Force clean compilation with -Werror X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Our driver compiles clean (nowadays thanks to 0day) but for me, at least, it would be beneficial if the compiler threw an error rather than a warning when it found a piece of suspect code. (I use this to compile-check patch series and want to break on the first compiler error in order to fix the patch.) v2: Kick off a new "Debugging" submenu for i915.ko At this point, we applied it to the kernel and promptly kicked it out again as it broke buildbots (due to a compiler warning on 32bits): commit 908d759b210effb33d927a8cb6603a16448474e4 Author: Daniel Vetter Date: Tue May 26 07:46:21 2015 +0200 Revert "drm/i915: Force clean compilation with -Werror" v3: Avoid enabling -Werror for allyesconfig/allmodconfig builds, using COMPILE_TEST as a suitable proxy suggested by Andrew Morton. (Damien) Only make the option available for EXPERT to reinforce that the option should not be casually enabled. Signed-off-by: Chris Wilson Cc: Jani Nikula Cc: Damien Lespiau Reviewed-by: Daniel Vetter --- drivers/gpu/drm/i915/Kconfig.debug | 17 +++++++++++++++++ drivers/gpu/drm/i915/Makefile | 2 ++ 2 files changed, 19 insertions(+) diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug index 649a562ddf17..61485c8ba3a8 100644 --- a/drivers/gpu/drm/i915/Kconfig.debug +++ b/drivers/gpu/drm/i915/Kconfig.debug @@ -1,3 +1,20 @@ +config DRM_I915_WERROR + bool "Force GCC to throw an error instead of a warning when compiling" + # As this may inadvertently break the build, only allow the user + # to shoot oneself in the foot iff they aim really hard + depends on EXPERT + # We use the dependency on !COMPILE_TEST to not be enabled in + # allmodconfig or allyesconfig configurations + depends on !COMPILE_TEST + default n + help + Add -Werror to the build flags for (and only for) i915.ko. + Do not enable this unless you are writing code for the i915.ko module. + + Recommended for driver developers only. + + If in doubt, say "N". + config DRM_I915_DEBUG bool "Enable additional driver debugging" depends on DRM_I915 diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile index 7ffb51b0cbc2..0b88ba0f3c1f 100644 --- a/drivers/gpu/drm/i915/Makefile +++ b/drivers/gpu/drm/i915/Makefile @@ -2,6 +2,8 @@ # Makefile for the drm device driver. This driver provides support for the # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. +subdir-ccflags-$(CONFIG_DRM_I915_WERROR) := -Werror + # Please keep these build lists sorted! # core driver code