diff mbox

virtio-input: add parenthesis to const_le32

Message ID 1460387988-30034-1-git-send-email-kraxel@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Gerd Hoffmann April 11, 2016, 3:19 p.m. UTC 
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 include/hw/virtio/virtio-input.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Eric Blake April 11, 2016, 4:14 p.m. UTC | #1 
On 04/11/2016 09:19 AM, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  include/hw/virtio/virtio-input.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

An explanation would have been helpful.

>  #if defined(HOST_WORDS_BIGENDIAN)
>  # define const_le32(_x)                          \
> -    (((_x & 0x000000ffU) << 24) |                \

The problem you are fixing is that _x needs parenthesis.

> +    ((((_x) & 0x000000ffU) << 24) |              \

and you indeed added it, but I had to hunt because there was no
explanation in the commit message.

Reviewed-by: Eric Blake <eblake@redhat.com>
diff mbox

Patch

diff --git a/include/hw/virtio/virtio-input.h b/include/hw/virtio/virtio-input.h
index af1c207..6d81c7c 100644
--- a/include/hw/virtio/virtio-input.h
+++ b/include/hw/virtio/virtio-input.h
@@ -15,10 +15,10 @@  typedef struct virtio_input_event virtio_input_event;
 
 #if defined(HOST_WORDS_BIGENDIAN)
 # define const_le32(_x)                          \
-    (((_x & 0x000000ffU) << 24) |                \
-     ((_x & 0x0000ff00U) <<  8) |                \
-     ((_x & 0x00ff0000U) >>  8) |                \
-     ((_x & 0xff000000U) >> 24))
+    ((((_x) & 0x000000ffU) << 24) |              \
+     (((_x) & 0x0000ff00U) <<  8) |              \
+     (((_x) & 0x00ff0000U) >>  8) |              \
+     (((_x) & 0xff000000U) >> 24))
 # define const_le16(_x)                          \
     (((_x & 0x00ff) << 8) |                      \
      ((_x & 0xff00) >> 8))