[06/20] mtip32xx: switch to using blk_queue_write_cache()
diff mbox

Message ID 1460486175-25724-7-git-send-email-axboe@fb.com
State New
Headers show

Commit Message

Jens Axboe April 12, 2016, 6:36 p.m. UTC
Signed-off-by: Jens Axboe <axboe@fb.com>
---
 drivers/block/mtip32xx/mtip32xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christoph Hellwig April 12, 2016, 9:22 p.m. UTC | #1
On Tue, Apr 12, 2016 at 12:36:01PM -0600, Jens Axboe wrote:
> Signed-off-by: Jens Axboe <axboe@fb.com>
> ---
>  drivers/block/mtip32xx/mtip32xx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
> index 25824c1697c5..6b5c30ff5547 100644
> --- a/drivers/block/mtip32xx/mtip32xx.c
> +++ b/drivers/block/mtip32xx/mtip32xx.c
> @@ -4027,7 +4027,7 @@ skip_create_disk:
>  	 * write back cache is not supported in the device. FUA depends on
>  	 * write back cache support, hence setting flush support to zero.
>  	 */
> -	blk_queue_flush(dd->queue, 0);
> +	blk_queue_write_cache(dd->queue, false, false);

I think this can simply be removed..
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jens Axboe April 12, 2016, 9:38 p.m. UTC | #2
On 04/12/2016 03:22 PM, Christoph Hellwig wrote:
> On Tue, Apr 12, 2016 at 12:36:01PM -0600, Jens Axboe wrote:
>> Signed-off-by: Jens Axboe <axboe@fb.com>
>> ---
>>   drivers/block/mtip32xx/mtip32xx.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
>> index 25824c1697c5..6b5c30ff5547 100644
>> --- a/drivers/block/mtip32xx/mtip32xx.c
>> +++ b/drivers/block/mtip32xx/mtip32xx.c
>> @@ -4027,7 +4027,7 @@ skip_create_disk:
>>   	 * write back cache is not supported in the device. FUA depends on
>>   	 * write back cache support, hence setting flush support to zero.
>>   	 */
>> -	blk_queue_flush(dd->queue, 0);
>> +	blk_queue_write_cache(dd->queue, false, false);
>
> I think this can simply be removed..

Functionally it can, question is if we want to keep it as documentation, 
or just kill the call and the comment?
Christoph Hellwig April 12, 2016, 9:39 p.m. UTC | #3
On Tue, Apr 12, 2016 at 03:38:47PM -0600, Jens Axboe wrote:
>>> -	blk_queue_flush(dd->queue, 0);
>>> +	blk_queue_write_cache(dd->queue, false, false);
>>
>> I think this can simply be removed..
>
> Functionally it can, question is if we want to keep it as documentation, or 
> just kill the call and the comment?

I'd just kill it all.
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jens Axboe April 12, 2016, 9:47 p.m. UTC | #4
On 04/12/2016 03:39 PM, Christoph Hellwig wrote:
> On Tue, Apr 12, 2016 at 03:38:47PM -0600, Jens Axboe wrote:
>>>> -	blk_queue_flush(dd->queue, 0);
>>>> +	blk_queue_write_cache(dd->queue, false, false);
>>>
>>> I think this can simply be removed..
>>
>> Functionally it can, question is if we want to keep it as documentation, or
>> just kill the call and the comment?
>
> I'd just kill it all.

Done

Patch
diff mbox

diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 25824c1697c5..6b5c30ff5547 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -4027,7 +4027,7 @@  skip_create_disk:
 	 * write back cache is not supported in the device. FUA depends on
 	 * write back cache support, hence setting flush support to zero.
 	 */
-	blk_queue_flush(dd->queue, 0);
+	blk_queue_write_cache(dd->queue, false, false);
 
 	/* Signal trim support */
 	if (dd->trim_supp == true) {