[v3,4/5] brd: Accept non-aligned discard requests with size zero
diff mbox

Message ID 570D5D35.2020501@sandisk.com
State New
Headers show

Commit Message

Bart Van Assche April 12, 2016, 8:40 p.m. UTC
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Mike Snitzer <snitzer@redhat.com>
Cc: Martin K. Petersen <martin.petersen@oracle.com>
Cc: Dmitry Monakhov <dmonakhov@openvz.org>
---
 drivers/block/brd.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Hannes Reinecke April 13, 2016, 5:50 a.m. UTC | #1
On 04/12/2016 10:40 PM, Bart Van Assche wrote:
> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Mike Snitzer <snitzer@redhat.com>
> Cc: Martin K. Petersen <martin.petersen@oracle.com>
> Cc: Dmitry Monakhov <dmonakhov@openvz.org>
> ---
>  drivers/block/brd.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/block/brd.c b/drivers/block/brd.c
> index 91eb844..9806551 100644
> --- a/drivers/block/brd.c
> +++ b/drivers/block/brd.c
> @@ -342,8 +342,9 @@ static blk_qc_t brd_make_request(struct request_queue *q, struct bio *bio)
>  	blk_queue_split(q, &bio, q->bio_split);
>  
>  	if (unlikely(bio->bi_rw & REQ_DISCARD)) {
> -		if (sector & ((PAGE_SIZE >> SECTOR_SHIFT) - 1) ||
> -		    bio->bi_iter.bi_size & ~PAGE_MASK)
> +		if (bio->bi_iter.bi_size &&
> +		    (sector & ((PAGE_SIZE >> SECTOR_SHIFT) - 1) ||
> +		     bio->bi_iter.bi_size & ~PAGE_MASK))
>  			goto io_error;
>  		discard_from_brd(brd, sector, bio->bi_iter.bi_size);
>  		goto out;
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes

Patch
diff mbox

diff --git a/drivers/block/brd.c b/drivers/block/brd.c
index 91eb844..9806551 100644
--- a/drivers/block/brd.c
+++ b/drivers/block/brd.c
@@ -342,8 +342,9 @@  static blk_qc_t brd_make_request(struct request_queue *q, struct bio *bio)
 	blk_queue_split(q, &bio, q->bio_split);
 
 	if (unlikely(bio->bi_rw & REQ_DISCARD)) {
-		if (sector & ((PAGE_SIZE >> SECTOR_SHIFT) - 1) ||
-		    bio->bi_iter.bi_size & ~PAGE_MASK)
+		if (bio->bi_iter.bi_size &&
+		    (sector & ((PAGE_SIZE >> SECTOR_SHIFT) - 1) ||
+		     bio->bi_iter.bi_size & ~PAGE_MASK))
 			goto io_error;
 		discard_from_brd(brd, sector, bio->bi_iter.bi_size);
 		goto out;