diff mbox

[11/14] drm/tilcdc: use drm_crtc_send_vblank_event()

Message ID 1460656118-16766-11-git-send-email-gustavo@padovan.org (mailing list archive)
State New, archived
Headers show

Commit Message

Gustavo Padovan April 14, 2016, 5:48 p.m. UTC
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

Replace the legacy drm_send_vblank_event() with the new helper function.

Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
---
 drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jyri Sarha April 19, 2016, 12:56 p.m. UTC | #1
On 04/14/16 20:48, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> 
> Replace the legacy drm_send_vblank_event() with the new helper function.
> 
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

Reviewed-by: Jyri Sarha <jsarha@ti.com>
Tested-by: Jyri Sarha <jsarha@ti.com>

Thanks!
Do you prefer me to pick this one to my next pull request?

Best regards,
Jyri

> ---
>  drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> index 051e5e1..79027b1 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> @@ -707,7 +707,7 @@ irqreturn_t tilcdc_crtc_irq(struct drm_crtc *crtc)
>  			event = tilcdc_crtc->event;
>  			tilcdc_crtc->event = NULL;
>  			if (event)
> -				drm_send_vblank_event(dev, 0, event);
> +				drm_crtc_send_vblank_event(crtc, event);
>  
>  			spin_unlock_irqrestore(&dev->event_lock, flags);
>  		}
>
Gustavo Padovan April 19, 2016, 2:03 p.m. UTC | #2
Hi Jyri,

2016-04-19 Jyri Sarha <jsarha@ti.com>:

> On 04/14/16 20:48, Gustavo Padovan wrote:
> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > 
> > Replace the legacy drm_send_vblank_event() with the new helper function.
> > 
> > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> 
> Reviewed-by: Jyri Sarha <jsarha@ti.com>
> Tested-by: Jyri Sarha <jsarha@ti.com>
> 
> Thanks!
> Do you prefer me to pick this one to my next pull request?

Yes, please pick it.

	Gustavo
Daniel Vetter May 2, 2016, 3:05 p.m. UTC | #3
On Tue, Apr 19, 2016 at 11:03:26AM -0300, Gustavo Padovan wrote:
> Hi Jyri,
> 
> 2016-04-19 Jyri Sarha <jsarha@ti.com>:
> 
> > On 04/14/16 20:48, Gustavo Padovan wrote:
> > > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > > 
> > > Replace the legacy drm_send_vblank_event() with the new helper function.
> > > 
> > > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > 
> > Reviewed-by: Jyri Sarha <jsarha@ti.com>
> > Tested-by: Jyri Sarha <jsarha@ti.com>
> > 
> > Thanks!
> > Do you prefer me to pick this one to my next pull request?
> 
> Yes, please pick it.

I didn't see a confirmation, so smashed it into drm-misc.

Thanks, Daniel
Jyri Sarha May 2, 2016, 6:58 p.m. UTC | #4
On 05/02/16 18:05, Daniel Vetter wrote:
> On Tue, Apr 19, 2016 at 11:03:26AM -0300, Gustavo Padovan wrote:
>> Hi Jyri,
>>
>> 2016-04-19 Jyri Sarha <jsarha@ti.com>:
>>
>>> On 04/14/16 20:48, Gustavo Padovan wrote:
>>>> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>>>>
>>>> Replace the legacy drm_send_vblank_event() with the new helper function.
>>>>
>>>> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>>>
>>> Reviewed-by: Jyri Sarha <jsarha@ti.com>
>>> Tested-by: Jyri Sarha <jsarha@ti.com>
>>>
>>> Thanks!
>>> Do you prefer me to pick this one to my next pull request?
>>
>> Yes, please pick it.
> 
> I didn't see a confirmation, so smashed it into drm-misc.
> 
> Thanks, Daniel
> 

Ok, thanks. My tilcdc atomic modeset patches are kind stalled and
without them I do not have too anything else put in the a pull req
anyway. I'll drop the patch from my branch.

BR,
Jyri
diff mbox

Patch

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
index 051e5e1..79027b1 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
@@ -707,7 +707,7 @@  irqreturn_t tilcdc_crtc_irq(struct drm_crtc *crtc)
 			event = tilcdc_crtc->event;
 			tilcdc_crtc->event = NULL;
 			if (event)
-				drm_send_vblank_event(dev, 0, event);
+				drm_crtc_send_vblank_event(crtc, event);
 
 			spin_unlock_irqrestore(&dev->event_lock, flags);
 		}