[00/45] KVM: arm/arm64: Rework virtual GIC emulation
diff mbox

Message ID 1461061586-15012-1-git-send-email-andre.przywara@arm.com
State New
Headers show

Commit Message

André Przywara April 19, 2016, 10:26 a.m. UTC
Hi Vladimir,

can you try the attached patch on top of the series to see if this
fixes the GICv3 emulation issues you see?

I think these lines got lost during the MMIO framework rebasing.

Cheers,
Andre.

---
 virt/kvm/arm/vgic/vgic_mmio.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Vladimir Murzin April 19, 2016, 12:04 p.m. UTC | #1
On 19/04/16 11:26, Andre Przywara wrote:
> Hi Vladimir,
> 
> can you try the attached patch on top of the series to see if this
> fixes the GICv3 emulation issues you see?
> 

With attached patch I don't see issue any more - all 255 vcpus are able
to boot and send/receive self SGI.

Thanks
Vladimir

> I think these lines got lost during the MMIO framework rebasing.
> 
> Cheers,
> Andre.
> 
> ---
>  virt/kvm/arm/vgic/vgic_mmio.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/virt/kvm/arm/vgic/vgic_mmio.c b/virt/kvm/arm/vgic/vgic_mmio.c
> index ec96188..92f39ba 100644
> --- a/virt/kvm/arm/vgic/vgic_mmio.c
> +++ b/virt/kvm/arm/vgic/vgic_mmio.c
> @@ -1228,6 +1228,7 @@ int vgic_register_redist_iodevs(struct kvm *kvm, gpa_t redist_base_address)
>  	kvm_for_each_vcpu(c, vcpu, kvm) {
>  		kvm_iodevice_init(&region->dev, &kvm_io_v3redist_ops);
>  		region->base_addr = redist_base_address;
> +		region->redist_vcpu = vcpu;
>  
>  		mutex_lock(&kvm->slots_lock);
>  		ret = kvm_io_bus_register_dev(kvm, KVM_MMIO_BUS,
> @@ -1241,6 +1242,7 @@ int vgic_register_redist_iodevs(struct kvm *kvm, gpa_t redist_base_address)
>  		region++;
>  		kvm_iodevice_init(&region->dev, &kvm_io_v3redist_private_ops);
>  		region->base_addr = redist_base_address + SZ_64K;
> +		region->redist_vcpu = vcpu;
>  
>  		mutex_lock(&kvm->slots_lock);
>  		ret = kvm_io_bus_register_dev(kvm, KVM_MMIO_BUS,
> 

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/virt/kvm/arm/vgic/vgic_mmio.c b/virt/kvm/arm/vgic/vgic_mmio.c
index ec96188..92f39ba 100644
--- a/virt/kvm/arm/vgic/vgic_mmio.c
+++ b/virt/kvm/arm/vgic/vgic_mmio.c
@@ -1228,6 +1228,7 @@  int vgic_register_redist_iodevs(struct kvm *kvm, gpa_t redist_base_address)
 	kvm_for_each_vcpu(c, vcpu, kvm) {
 		kvm_iodevice_init(&region->dev, &kvm_io_v3redist_ops);
 		region->base_addr = redist_base_address;
+		region->redist_vcpu = vcpu;
 
 		mutex_lock(&kvm->slots_lock);
 		ret = kvm_io_bus_register_dev(kvm, KVM_MMIO_BUS,
@@ -1241,6 +1242,7 @@  int vgic_register_redist_iodevs(struct kvm *kvm, gpa_t redist_base_address)
 		region++;
 		kvm_iodevice_init(&region->dev, &kvm_io_v3redist_private_ops);
 		region->base_addr = redist_base_address + SZ_64K;
+		region->redist_vcpu = vcpu;
 
 		mutex_lock(&kvm->slots_lock);
 		ret = kvm_io_bus_register_dev(kvm, KVM_MMIO_BUS,