diff mbox

[v4,1/3] mmc: dt: usdhi6rol0: add optional pinctrl binding

Message ID a96281244b55d55e36b72a40cd061d7ffd70b88e.1461246772.git.larper@axis.com (mailing list archive)
State New, archived
Headers show

Commit Message

Lars Persson April 21, 2016, 1:55 p.m. UTC
Add a pinctrl binding to specify different pin settings for high speed
modes and UHS modes.

Signed-off-by: Lars Persson <larper@axis.com>
---
 Documentation/devicetree/bindings/mmc/usdhi6rol0.txt | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Rob Herring April 22, 2016, 8:27 p.m. UTC | #1
On Thu, Apr 21, 2016 at 03:55:42PM +0200, Lars Persson wrote:
> Add a pinctrl binding to specify different pin settings for high speed
> modes and UHS modes.
> 
> Signed-off-by: Lars Persson <larper@axis.com>
> ---
>  Documentation/devicetree/bindings/mmc/usdhi6rol0.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt b/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
> index 8babdaa..6d1b797 100644
> --- a/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
> +++ b/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
> @@ -12,6 +12,12 @@ Optional properties:
>  
>  - vmmc-supply:	a phandle of a regulator, supplying Vcc to the card
>  - vqmmc-supply:	a phandle of a regulator, supplying VccQ to the card
> +- pinctrl-names: Can contain a "default" entry and a "state_uhs"

Don't use underscores. Just "uhs" should be sufficient, right?

> +                 entry. The state_uhs entry is used together with the default
> +                 entry when the board requires distinct settings for UHS speeds.
> +
> +- pinctrl-N: One property for each name listed in pinctrl-names, see
> +             ../pinctrl/pinctrl-bindings.txt.
>  
>  Additionally any standard mmc bindings from mmc.txt can be used.
>  
> -- 
> 2.1.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Lars Persson April 26, 2016, 12:23 p.m. UTC | #2
On 04/22/2016 10:27 PM, Rob Herring wrote:
> On Thu, Apr 21, 2016 at 03:55:42PM +0200, Lars Persson wrote:
>> Add a pinctrl binding to specify different pin settings for high speed
>> modes and UHS modes.
>>
>> Signed-off-by: Lars Persson <larper@axis.com>
>> ---
>>   Documentation/devicetree/bindings/mmc/usdhi6rol0.txt | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt b/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
>> index 8babdaa..6d1b797 100644
>> --- a/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
>> +++ b/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
>> @@ -12,6 +12,12 @@ Optional properties:
>>
>>   - vmmc-supply:	a phandle of a regulator, supplying Vcc to the card
>>   - vqmmc-supply:	a phandle of a regulator, supplying VccQ to the card
>> +- pinctrl-names: Can contain a "default" entry and a "state_uhs"
>
> Don't use underscores. Just "uhs" should be sufficient, right?

I do not object to this, but for consistency it seems better with 
state_uhs that existing bindings use.

>
>> +                 entry. The state_uhs entry is used together with the default
>> +                 entry when the board requires distinct settings for UHS speeds.
>> +
>> +- pinctrl-N: One property for each name listed in pinctrl-names, see
>> +             ../pinctrl/pinctrl-bindings.txt.
>>
>>   Additionally any standard mmc bindings from mmc.txt can be used.
>>
>> --
>> 2.1.4
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Herring April 26, 2016, 1:19 p.m. UTC | #3
On Tue, Apr 26, 2016 at 7:23 AM, Lars Persson <lars.persson@axis.com> wrote:
>
>
> On 04/22/2016 10:27 PM, Rob Herring wrote:
>>
>> On Thu, Apr 21, 2016 at 03:55:42PM +0200, Lars Persson wrote:
>>>
>>> Add a pinctrl binding to specify different pin settings for high speed
>>> modes and UHS modes.
>>>
>>> Signed-off-by: Lars Persson <larper@axis.com>
>>> ---
>>>   Documentation/devicetree/bindings/mmc/usdhi6rol0.txt | 6 ++++++
>>>   1 file changed, 6 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
>>> b/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
>>> index 8babdaa..6d1b797 100644
>>> --- a/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
>>> +++ b/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
>>> @@ -12,6 +12,12 @@ Optional properties:
>>>
>>>   - vmmc-supply:        a phandle of a regulator, supplying Vcc to the
>>> card
>>>   - vqmmc-supply:       a phandle of a regulator, supplying VccQ to the
>>> card
>>> +- pinctrl-names: Can contain a "default" entry and a "state_uhs"
>>
>>
>> Don't use underscores. Just "uhs" should be sufficient, right?
>
>
> I do not object to this, but for consistency it seems better with state_uhs
> that existing bindings use.

Okay. Consistency is better.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt b/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
index 8babdaa..6d1b797 100644
--- a/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
+++ b/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
@@ -12,6 +12,12 @@  Optional properties:
 
 - vmmc-supply:	a phandle of a regulator, supplying Vcc to the card
 - vqmmc-supply:	a phandle of a regulator, supplying VccQ to the card
+- pinctrl-names: Can contain a "default" entry and a "state_uhs"
+                 entry. The state_uhs entry is used together with the default
+                 entry when the board requires distinct settings for UHS speeds.
+
+- pinctrl-N: One property for each name listed in pinctrl-names, see
+             ../pinctrl/pinctrl-bindings.txt.
 
 Additionally any standard mmc bindings from mmc.txt can be used.