diff mbox

[RESEND,v2,3/4] ARM64: dts: rockchip: add RK3399 evaluation board

Message ID 1461304307-14113-4-git-send-email-jay.xu@rock-chips.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jianqun Xu April 22, 2016, 5:51 a.m. UTC
The RK3399 evaluation board is designed with pmic
rk808 on top board.

Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
---
changes in v2:
- new add patch

 Documentation/devicetree/bindings/arm/rockchip.txt | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Rob Herring April 22, 2016, 8:33 p.m. UTC | #1
On Fri, Apr 22, 2016 at 01:51:46PM +0800, Jianqun Xu wrote:
> The RK3399 evaluation board is designed with pmic
> rk808 on top board.
> 
> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
> ---
> changes in v2:
> - new add patch
> 
>  Documentation/devicetree/bindings/arm/rockchip.txt | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Acked-by: Rob Herring <robh@kernel.org>
Brian Norris April 25, 2016, 11:22 p.m. UTC | #2
On Fri, Apr 22, 2016 at 01:51:46PM +0800, Jianqun Xu wrote:
> The RK3399 evaluation board is designed with pmic
> rk808 on top board.
> 
> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
> ---
> changes in v2:
> - new add patch

FWIW, the $subject is a bit confusing. Probaly should be "Documentation:
...". But otherwise, LGTM.
Jianqun Xu April 26, 2016, 1:22 a.m. UTC | #3
Hi Brian:

On 2016?04?26? 07:22, Brian Norris wrote:
> On Fri, Apr 22, 2016 at 01:51:46PM +0800, Jianqun Xu wrote:
>> The RK3399 evaluation board is designed with pmic
>> rk808 on top board.
>>
>> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
>> ---
>> changes in v2:
>> - new add patch
>
> FWIW, the $subject is a bit confusing. Probaly should be "Documentation:
> ...". But otherwise, LGTM.
>
>
ok, I will fix it in next version, thanks ~
>
Jianqun Xu April 26, 2016, 1:30 a.m. UTC | #4
Hi Brian:

On 2016?04?26? 07:22, Brian Norris wrote:
> On Fri, Apr 22, 2016 at 01:51:46PM +0800, Jianqun Xu wrote:
>> The RK3399 evaluation board is designed with pmic
>> rk808 on top board.
>>
>> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
>> ---
>> changes in v2:
>> - new add patch
>
> FWIW, the $subject is a bit confusing. Probaly should be "Documentation:
> ...". But otherwise, LGTM.
>
yes, I will fix it in next version, thanks
>
>
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt b/Documentation/devicetree/bindings/arm/rockchip.txt
index 2549519..6491b56 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.txt
+++ b/Documentation/devicetree/bindings/arm/rockchip.txt
@@ -101,4 +101,8 @@  Rockchip platforms device tree bindings
 
 - Rockchip RK3228 Evaluation board:
     Required root node properties:
-      - compatible = "rockchip,rk3228-evb", "rockchip,rk3228";
+     - compatible = "rockchip,rk3228-evb", "rockchip,rk3228";
+
+- Rockchip RK3399 evb:
+    Required root node properties:
+      - compatible = "rockchip,rk3399-evb", "rockchip,rk3399";